fix: change enum to bool

VenusProtocol · Sep 16, 2024 · 0cde6c2 · 0cde6c2
1 parent a6dee6b
commit 0cde6c2
Show file tree

Hide file tree

Showing 2 changed files with 1,087 additions and 1,100 deletions.
diff --git a/contracts/Governance/ACMCommandsAggregator.sol b/contracts/Governance/ACMCommandsAggregator.sol
@@ -4,22 +4,14 @@ pragma solidity 0.8.25;
 import { IAccessControlManagerV8 } from "../Governance/IAccessControlManagerV8.sol";
 
 contract ACMCommandsAggregator {
-    /*
-     * @notice Enum to differentiate between giving and revoking permissions
-     */
-    enum PermissionType {
-        GIVE,
-        REVOKE
-    }
-
     /*
      * @notice Struct to store permission details
      */
     struct Permission {
         /*
-         * @notice Type of permission
+         * @notice Type of permission (Give(false)/Revoke(true))
          */
-        PermissionType permissionType;
+        bool permissionType;
         /*
          * @notice Address of the contract
          */
@@ -100,7 +92,7 @@ contract ACMCommandsAggregator {
     function executePermissions(uint256 index) external {
         uint256 length = permissions[index].length;
         for (uint256 i = 0; i < length; i++) {
-            if (permissions[index][i].permissionType == PermissionType.GIVE) {
+            if (permissions[index][i].permissionType == false) {
                 ACM.giveCallPermission(
                     permissions[index][i].contractAddress,
                     permissions[index][i].functionSig,