Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multiple Reward Distributors with same Reward Token #290

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Support Multiple Reward Distributors with same Reward Token #290

merged 1 commit into from
Aug 18, 2023
+47 −14

Conversation

web3rover
Copy link
Collaborator

@web3rover web3rover commented Aug 16, 2023 •
edited
Loading

Description

Resolves #VEN-1821

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 76% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 99% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 97% (1451 / 1501) 75% (441 / 590) ✔

Debugger022
Debugger022 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Debugger022 Debugger022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@web3rover web3rover merged commit c2286e8 into develop Aug 18, 2023
3 checks passed
@web3rover web3rover deleted the feat/support-duplicate-reward-token branch August 18, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkirka kkirka kkirka approved these changes

@0xlucian 0xlucian 0xlucian approved these changes

@Debugger022 Debugger022 Debugger022 approved these changes

@chechu chechu Awaiting requested review from chechu

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@web3rover web3rover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web3rover @kkirka @0xlucian @Debugger022