Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-1823]: deployment of TWT market #295

Merged
merged 12 commits into from
Dec 19, 2023
Merged

[VEN-1823]: deployment of TWT market #295

merged 12 commits into from
Dec 19, 2023

Conversation

GitGuru7
Copy link
Contributor

Description

Deployment of THE and TWT market.

Resolves VEN-1823

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Aug 23, 2023
0xlucian
0xlucian previously approved these changes Aug 23, 2023
View reviewed changes
chechu
chechu reviewed Aug 24, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu previously approved these changes Aug 24, 2023
View reviewed changes
@chechu chechu dismissed their stale review August 24, 2023 10:29

We need to add the config of the Oracles

chechu
chechu previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget my comment about Oracles. It has to be done in the VIP (VenusProtocol/vips#60), not here

chechu
chechu reviewed Aug 25, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Aug 28, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
chechu
chechu previously approved these changes Aug 29, 2023
View reviewed changes
chechu
chechu reviewed Sep 20, 2023
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@chechu chechu changed the title [VEN-1823]: deployments of THE and TWT market [VEN-1823]: deployments of TWT market Dec 12, 2023
@chechu chechu changed the title [VEN-1823]: deployments of TWT market [VEN-1823]: deployment of TWT market Dec 12, 2023
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 78% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 89% 61% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 96% (1451 / 1513) 75% (449 / 602) ✔

@GitGuru7 GitGuru7 merged commit f5b767f into develop Dec 19, 2023
4 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@0xlucian 0xlucian 0xlucian left review comments

@kkirka kkirka Awaiting requested review from kkirka

@Debugger022 Debugger022 Awaiting requested review from Debugger022

Assignees

@GitGuru7 GitGuru7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GitGuru7 @chechu @0xlucian