Add forked deployment #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
add-forked-deployment
branch
from
aecd6de
to
2a01c75
Compare
kkirka
previously approved these changes
Oct 9, 2024
Comment on lines
43
to
20
| if (owner !== targetOwner && pendingOwner !== targetOwner) { | ||
| if (owner.toLowerCase() !== targetOwner.toLowerCase() && pendingOwner.toLowerCase() !== targetOwner.toLowerCase()) { |
There was a problem hiding this comment.
I believe the convention should be to use checksummed addresses everywhere. This is what ethers returns in the calls, so we could avoid case conversions in this case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add supports for doing a "dry run" of deployments using hardhat. Require setting URI at variables
ARCHIVE_NODE_<NETWORK>and setting the network withHARDHAT_FORK_NETWORK.Without
HARDHAT_FORK_NETWORKset it will run like normal. WithHARDHAT_FORK_NETWORKset it runs on hardhat but overrides hardhat values with those of the forked networks