feat: add weETHs invariant event indexing #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
weeths-invariant-subgraph
branch
3 times, most recently
from
66fb45a
to
248dedf
Compare
coreyar
force-pushed
the
weeths-invariant-subgraph
branch
from
22d7e69
to
e558225
Compare
| toAccount.effective_balance.plus( | ||
| amountUnderlying.toBigDecimal().div(exponentToBigDecimal(18)), | ||
| ), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
nit: not needed anymore
Comment on lines
+50
to
+52
| effective_balance: BigDecimal! | ||
| "Token Address" | ||
| token: Borrow! |
There was a problem hiding this comment.
I see EtherFi expects the balance to be in tokens instead of mantissa, what about renaming type to token? Would the new schema affect queries?
There was a problem hiding this comment.
line 52 is not referencing a value, It is referencing a relationship to make it easy to query all borrowers or suppliers.
line 51 is the name etherfi is expecting
coreyar
force-pushed
the
weeths-invariant-subgraph
branch
from
e558225
to
29acca5
Compare
gleiser-oliveira
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add weETHs invariant support to etherfi subgraph