Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: list proposals on Proposal page #3347

Merged
merged 1 commit into from
Oct 7, 2024
Merged

refactor: list proposals on Proposal page #3347

merged 1 commit into from
Oct 7, 2024

Conversation

therealemjy
Copy link
Member

@therealemjy therealemjy commented Oct 5, 2024 •
edited
Loading

Jira ticket(s)

VEN-2701

Changes

  • add chainId property to ConnectWallet container component so it can also prompt user to switch chain if required
  • update Proposal page component to display commands

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3d8d05e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Oct 7, 2024 0:17am
dapp-preview ✅ Ready (Inspect) Visit Preview Oct 7, 2024 0:17am
dapp-testnet ✅ Ready (Inspect) Visit Preview Oct 7, 2024 0:17am
venus.io ✅ Ready (Inspect) Visit Preview Oct 7, 2024 0:17am

@vercel vercel bot temporarily deployed to Preview – venus.io October 5, 2024 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 5, 2024 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 5, 2024 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 5, 2024 16:15 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024 •
edited
Loading

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 79.22% 48338 / 61017
🔵 Statements 79.22% 48338 / 61017
🔵 Functions 70.59% 850 / 1204
🔵 Branches 83.36% 3974 / 4767
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/evm/src/containers/ConnectWallet/index.tsx 100% 100% 100% 100%
apps/evm/src/containers/ConnectWallet/Container/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/index.tsx 96.96% 96.55% 87.5% 96.96% 51-56
apps/evm/src/pages/Proposal/testIds.ts 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/BscCommand/index.tsx 97.08% 84.21% 100% 97.08% 82-85
apps/evm/src/pages/Proposal/Commands/BscCommand/ActionButton/index.tsx 94.87% 75% 100% 94.87% 56-57, 72-73, 88-89
apps/evm/src/pages/Proposal/Commands/BscCommand/CurrentStep/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/Command/index.tsx 100% 100% 50% 100%
apps/evm/src/pages/Proposal/Commands/Command/ActionsAccordion/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/Description/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/NonBscCommand/index.tsx 100% 100% 50% 100%
apps/evm/src/pages/Proposal/Commands/NonBscCommand/CurrentStep/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/Status/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/useIsProposalCancelableByUser/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/useIsProposalExecutable/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Description/index.tsx 94.73% 100% 100% 94.73% 64-67
Generated in workflow #9123 for commit 3d8d05e by the Vitest Coverage Report Action

@vercel vercel bot temporarily deployed to Preview – venus.io October 6, 2024 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 6, 2024 20:17 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 7, 2024 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 7, 2024 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – venus.io October 7, 2024 10:32 Inactive
@therealemjy therealemjy changed the title refactor: components to display proposal commands refactor: list proposals on Proposal page Oct 7, 2024
@therealemjy therealemjy marked this pull request as ready for review October 7, 2024 11:49
@therealemjy therealemjy merged commit 57bf495 into feat/multichain-governance Oct 7, 2024
6 checks passed
@therealemjy therealemjy deleted the refactor/command-component branch October 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleiser-oliveira gleiser-oliveira gleiser-oliveira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therealemjy @gleiser-oliveira