Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display executed payloads counts on proposal list #3354

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

therealemjy
Copy link
Member

@therealemjy therealemjy commented Oct 8, 2024

Jira ticket(s)

VEN-2701

Changes

  • create LabeledProgressCircle component
  • update rim size of "md" variant of ProgressCircle component
  • display executed payloads counts on proposal list
  • fix bug where "Cancel" button would show for proposal that could no longer be canceled

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 070e3d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-alt.venus.io ✅ Ready (Inspect) Visit Preview Oct 9, 2024 1:38pm
dapp-preview ✅ Ready (Inspect) Visit Preview Oct 9, 2024 1:38pm
dapp-testnet ✅ Ready (Inspect) Visit Preview Oct 9, 2024 1:38pm
venus.io ✅ Ready (Inspect) Visit Preview Oct 9, 2024 1:38pm

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 79.52% 48527 / 61019
🔵 Statements 79.52% 48527 / 61019
🔵 Functions 70.76% 857 / 1211
🔵 Branches 83.5% 4020 / 4814
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/evm/src/components/index.ts 100% 100% 100% 100%
apps/evm/src/components/LabeledProgressCircle/index.tsx 100% 100% 100% 100%
apps/evm/src/components/ProgressCircle/index.tsx 100% 100% 100% 100%
apps/evm/src/components/ProposalCard/styles.ts 100% 100% 100% 100%
apps/evm/src/pages/Governance/testIds.ts 100% 100% 100% 100%
apps/evm/src/pages/Governance/ProposalList/index.tsx 95.71% 95% 71.42% 95.71% 240-246, 259-260, 269-271
apps/evm/src/pages/Governance/ProposalList/GovernanceProposal/index.tsx 97.43% 74.19% 100% 97.43% 64, 66, 68, 93, 146
apps/evm/src/pages/Governance/ProposalList/GovernanceProposal/styles.ts 100% 100% 100% 100%
apps/evm/src/pages/Governance/ProposalList/GovernanceProposal/Status/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Governance/ProposalList/GovernanceProposal/Status/Indicator/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/BscCommand/CurrentStep/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/NonBscCommand/CurrentStep/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/Progress/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Proposal/Commands/useIsProposalCancelableByUser/index.tsx 100% 100% 100% 100%
apps/evm/src/utilities/index.ts 100% 100% 100% 100%
Generated in workflow #9145 for commit 070e3d1 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants