Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stable rate borrow #244

Open
wants to merge 206 commits into
base: develop
Choose a base branch
from
Open

Feature/stable rate borrow #244

wants to merge 206 commits into from

Conversation

Debugger022
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

kkirka and others added 30 commits April 4, 2023 18:25
@kkirka @Debugger022
test: add simulations for swapping the debt
aec462b
@Debugger022
Added diamond proxy structure
202f672
@Debugger022
Added reward and setter Facet
fd87920
@Debugger022
Added Helper libraries
6c5c7ef
@Debugger022
Update stroage access and fix Lint
1912289
@Debugger022
Update imports
1e4c321
@Debugger022
Added Policy and Market Facet
981c62d
@Debugger022
lint fix.
8f86561
@Debugger022
Added facet interface
6cef23b
@Debugger022
Update storage access in library
53860a3
@Debugger022
Fix: lint fix
0f31c2a
@Debugger022
Fix: lint fix
a41278c
@Debugger022
Added library and refactored diamond facets.
5756e61
@Debugger022
Upgraded solidity version from 0.5.16 to 0.8.13.
b46f80d
@Debugger022
Upgraded solidity version and refactor comptroller contracts.
ad098d4
@Debugger022
Upgraded solidity version and refactor vToken contracts.
12bf2f5
@Debugger022
Upgraded solidity version and refactor Test contracts.
83932ac
@Debugger022
Upgraded solidity version from 0.5.16 to 0.8.13.
fdc8ff4
@Debugger022
Fix: lint issues.
b234a2f
@Debugger022
Refactor LibHelper, PolicyFacet, RewardFacet and resolve errors.
3cb18d7
@Debugger022
Fixed lint.
25e26ba
@Debugger022
Fix: minor issues.
5601101
@Debugger022
Fixed tests.
310b950
@Debugger022
Added scripts for diamond proxy.
56a541f
@Debugger022
Fixed some issues.
f819efe
@Debugger022
Fixed diamond proxy issue.
2f61258
@Debugger022
Added access control tests for diamond proxy.
12ee219
@Debugger022
Refactored diamond proxy deployment script.
910103e
@Debugger022
Added tests for comptroller's diamond proxy.
b07d5a6
@Debugger022
Refactor VToken and ComptrollerLens.
d6f81f0
Debugger022 and others added 28 commits August 4, 2023 17:59
@Debugger022
revert: ven-1795 changes for n-08
fd07edd
@chechu
Merge pull request #312 from VenusProtocol/VEN-1795
728d618 
[VEN-1795] OZ Diamond Comptroller audit fixes
@Debugger022
merge branch 'develop' into feat/diamond-proxy
fb06750
@Debugger022
fix: ven-1887 ven-08
b745623
@Debugger022
fix: ven-1887 ven-12
0e24ded
@Debugger022
fix: ven-1887 ven-04
c60497a
@Debugger022
fix: lint
d09d8d3
@Debugger022
fix: replaced And operator with OR while checking cutoff
fa26e52
@Debugger022
refactor: netspec comments
547f77f
@Debugger022
feat: force liquidation implementation
cf9c7cb
@Debugger022
Revert "fix: ven-1887 ven-12"
c563562 
This reverts commit 0e24ded.
@Debugger022
fix: lint
a34816a
@Debugger022
[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy (#328)
df08df4 
* fix: ven-1887 ven-08

* fix: ven-1887 ven-12

* fix: ven-1887 ven-04

* fix: lint

* fix: replaced And operator with OR while checking cutoff

* refactor: netspec comments

* Revert "fix: ven-1887 ven-12"

This reverts commit 0e24ded.

* fix: lint
@Debugger022
Revert "[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy (
9af2d4a 
#328)" (#337)

This reverts commit df08df4.
@Debugger022
Merge pull request #338 from VenusProtocol/VEN-1887
3586e05 
[VEN-1887]: Quantstamp audit fix for comptroller diamond proxy
@Debugger022
refactor: optimized code
0af25d4
@Debugger022
fix: resolved conflicts
b4ddc09
@Debugger022
fix: resolved conflicts
1f1b0f9
@Debugger022
fix: pr comments
35b5517
@Debugger022
fix: merge branch 'develop' into feat/diamond-proxy
e6e9ca5
@Debugger022
fix: updated yarn.lock
032cc8e
@Debugger022
Merge pull request #335 from VenusProtocol/feat/force-liquidation-dia…
3313948 
…mond

[VEN-1929]: force liquidation functionality in diamond implementation of comptroller
@Debugger022
fix: merge branch 'feat/diamond-proxy' into feature/stable-rate-borrow
90d4138
@web3rover
Merge branch 'develop' into feat/diamond-proxy
6c0d496
@chechu
docs: add natspect to _setForcedLiquidation
456ad85
@Debugger022
fix: resolve merge conflicts
e3621e3
@Debugger022
fix: pr comments
0710b66
@Debugger022
fix: merge branch 'feat/diamond-proxy' into feature/stable-rate-borrow
63fc290
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Comptroller 100% 90% ✔
Comptroller.Diamond 95% 59% ✔
Comptroller.Diamond.facets 72% 62% ➖
Comptroller.Diamond.interfaces 100% 100% ✔
DelegateBorrowers 100% 86% ✔
Governance 26% 25% ❌
InterestRateModels 44% 39% ❌
Lens 41% 37% ❌
Liquidator 99% 89% ✔
Oracle 100% 100% ✔
PegStability 88% 84% ✔
Swap 88% 58% ✔
Swap.interfaces 100% 100% ✔
Swap.lib 81% 55% ✔
Tokens 100% 100% ✔
Tokens.VAI 71% 46% ➖
Tokens.VRT 20% 9% ❌
Tokens.VTokens 65% 47% ➖
Tokens.XVS 19% 8% ❌
Utils 58% 40% ➖
VRTVault 49% 36% ❌
Vault 50% 45% ➖
XVSVault 65% 52% ➖
Summary 60% (2559 / 4248) 44% (1050 / 2376) ➖

@chechu chechu added this to the 007 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkirka kkirka Awaiting requested review from kkirka

@chechu chechu Awaiting requested review from chechu

@web3rover web3rover Awaiting requested review from web3rover

@0xlucian 0xlucian Awaiting requested review from 0xlucian

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

At least 1 approving review is required to merge this pull request.

Assignees

@Debugger022 Debugger022

Labels
don't merge Need to merge after passing test
Projects
None yet
Milestone
007
Development

Successfully merging this pull request may close these issues.
4 participants
@Debugger022 @chechu @kkirka @web3rover