Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2066][VEN-2109]: add XVS vault deployment script #366

Merged
merged 8 commits into from
Nov 29, 2023
Merged

[VEN-2066][VEN-2109]: add XVS vault deployment script #366

merged 8 commits into from
Nov 29, 2023

Conversation

coreyar
Copy link
Collaborator

@coreyar coreyar commented Oct 6, 2023

Description

Adds deployment script for the XVS vault

@chechu chechu requested a review from GitGuru7 October 16, 2023 11:26
chechu
chechu reviewed Oct 16, 2023
View reviewed changes
deploy/007-deploy-vaults.ts Outdated Show resolved Hide resolved
@chechu chechu changed the title feat: add xvs vault deployment script [VEN-2066]: add xvs vault deployment script Oct 16, 2023
@chechu chechu changed the title [VEN-2066]: add xvs vault deployment script [VEN-2066]: add XVS vault deployment script Oct 16, 2023
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch from d56195d to d777c3f Compare October 19, 2023 14:06
kkirka
kkirka reviewed Oct 19, 2023
View reviewed changes
deploy/008-deploy-vaults.ts Outdated Show resolved Hide resolved
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch 2 times, most recently from 8cd995f to df5c35d Compare October 19, 2023 15:27
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch 2 times, most recently from b1d312a to 2d2e9ee Compare November 17, 2023 14:14
GitGuru7
GitGuru7 reviewed Nov 21, 2023
View reviewed changes
deploy/007-deploy-xvs.ts Outdated Show resolved Hide resolved
deploy/008-deploy-vaults.ts Outdated Show resolved Hide resolved
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch from 2d2e9ee to cd10350 Compare November 21, 2023 12:05
@GitGuru7 GitGuru7 mentioned this pull request Nov 23, 2023
Closed
4 tasks
@GitGuru7 GitGuru7 changed the title [VEN-2066]: add XVS vault deployment script [VEN-2066][VEN-2109]: add XVS vault deployment script Nov 23, 2023
@GitGuru7 GitGuru7 force-pushed the add-xvs-vault-deployment-script branch from ff1959d to 7ddac1a Compare November 23, 2023 12:49
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch from 7ddac1a to cdb2395 Compare November 28, 2023 15:17
chechu
chechu reviewed Nov 29, 2023
View reviewed changes
deploy/009-configure-vaults.ts Outdated Show resolved Hide resolved
deploy/009-configure-vaults.ts Show resolved Hide resolved
@chechu chechu mentioned this pull request Nov 29, 2023
Merged
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch from 0a9798a to e7e0572 Compare November 29, 2023 17:20
@coreyar coreyar force-pushed the add-xvs-vault-deployment-script branch from ae01f95 to 03581c8 Compare November 29, 2023 20:03
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Admin 88% 41% ✔
Comptroller 100% 90% ✔
Comptroller.Diamond 95% 59% ✔
Comptroller.Diamond.facets 77% 66% ➖
Comptroller.Diamond.interfaces 100% 100% ✔
DelegateBorrowers 100% 86% ✔
Governance 0% 0% ❌
InterestRateModels 47% 67% ❌
Lens 44% 37% ❌
Liquidator 98% 80% ✔
Oracle 100% 100% ✔
PegStability 88% 84% ✔
Swap 88% 58% ✔
Swap.interfaces 100% 100% ✔
Swap.lib 81% 55% ✔
Tokens 100% 100% ✔
Tokens.Prime 97% 72% ✔
Tokens.Prime.Interfaces 100% 100% ✔
Tokens.Prime.libs 90% 76% ✔
Tokens.VAI 71% 46% ➖
Tokens.VRT 20% 9% ❌
Tokens.VTokens 56% 35% ➖
Tokens.XVS 19% 8% ❌
Utils 49% 29% ❌
VAIVault 50% 45% ➖
VRTVault 49% 36% ❌
XVSVault 64% 50% ➖
Summary 67% (2942 / 4389) 47% (1100 / 2318) ➖

@coreyar coreyar merged commit dd58260 into develop Nov 29, 2023
4 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkirka kkirka kkirka left review comments

@GitGuru7 GitGuru7 GitGuru7 left review comments

@chechu chechu chechu approved these changes

@0xlucian 0xlucian Awaiting requested review from 0xlucian

Assignees

@coreyar coreyar

Labels
multichain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coreyar @chechu @kkirka @GitGuru7