Skip to content

Commit

Permalink
feat: rename multisig TX bc it will replace #46 and add description f…
Browse files Browse the repository at this point in the history
…or VIP 340
  • Loading branch information
chechu committed Jul 17, 2024
1 parent a9f4ffc commit 816c015
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { expect } from "chai";
import { ethers } from "hardhat";
import { forking, pretendExecutingVip } from "src/vip-framework";

import vip047, { COMPTROLLER_CORE, COMPTROLLER_CURVE, PRIME } from "../../../proposals/ethereum/vip-047";
import vip046, { COMPTROLLER_CORE, COMPTROLLER_CURVE, PRIME } from "../../../proposals/ethereum/vip-046";
import COMPTROLLER_ABI from "./abi/ILComptroller.json";

forking(20321056, async () => {
const provider = ethers.provider;

describe("Post-VIP behavior", () => {
before(async () => {
await pretendExecutingVip(await vip047());
await pretendExecutingVip(await vip046());
});

it("Comptroller Core should have correct Prime token address", async () => {
Expand Down
21 changes: 19 additions & 2 deletions vips/vip-340/bscmainnet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,25 @@ const CRITICAL_TIMELOCK = "0x213c446ec11e45b15a6E29C1C1b402B8897f606d";
const vip340 = () => {
const meta = {
version: "v2",
title: "VIP-340 [Ethereum] Automatization of Prime update",
description: ``,
title: "VIP-340 [Ethereum] Prime synchronisation in the Core and Curve pools",
description: `If passed, this VIP allows the automatic update of the Prime rewards every time a Prime holder interacts with a Prime market of the Core and Curve pools.
#### Security and additional considerations
We applied the following security procedures for this upgrade:
- **VIP execution simulation**: in a simulation environment, validating the new configuration is the expected one
- This VIP doesn’t upgrade any smart contract. It only configures the Prime contract on the Core and Curve comptrollers
#### References
- [VIP simulation](https://github.com/VenusProtocol/vips/pull/324)
- [VIP-339 [Ethereum] : Venus Prime Deployment - Q3 2024](https://app.venus.io/#/governance/proposal/339)
- [Documentation](https://docs-v4.venus.io/whats-new/prime-yield)
#### Disclaimer for Ethereum VIPs
Privilege commands on Ethereum will be executed by the [Guardian wallet](https://etherscan.io/address/0x285960C5B22fD66A736C7136967A3eB15e93CC67), until the [Multichain Governance](https://docs-v4.venus.io/technical-reference/reference-technical-articles/multichain-governance) contracts are fully enabled. If this VIP passes, [this](https://app.safe.global/transactions/tx?safe=eth:0x285960C5B22fD66A736C7136967A3eB15e93CC67&id=multisig_0x285960C5B22fD66A736C7136967A3eB15e93CC67_0x2aab4f994d730c4a9ec9dcdcbc348bc6a9e5d7ed7995927671f938c636a6fd86) multisig transaction will be executed. Otherwise, it will be rejected.`,
forDescription: "Execute this proposal",
againstDescription: "Do not execute this proposal",
abstainDescription: "Indifferent to execution",
Expand Down

0 comments on commit 816c015

Please sign in to comment.