Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2682]: Vip for XVS bridge for zksyncsepolia #340

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[VEN-2682]: Vip for XVS bridge for zksyncsepolia #340

merged 1 commit into from
Aug 6, 2024

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Aug 5, 2024

Description

Resolves VEN

@GitGuru7 GitGuru7 self-assigned this Aug 5, 2024
chechu
chechu approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TX lgtm, but AFAIK we would need also a TX on each destination network, setting the trustworthiness relationship with the bridge contract on zkSync sepolia. That could be done in a different PR to reduce the overlap

@GitGuru7
Copy link
Contributor Author

GitGuru7 commented Aug 6, 2024

This TX lgtm, but AFAIK we would need also a TX on each destination network, setting the trustworthiness relationship with the bridge contract on zkSync sepolia. That could be done in a different PR to reduce the overlap

Yes we'll do.

@GitGuru7
Copy link
Contributor Author

GitGuru7 commented Aug 6, 2024

https://sepolia.explorer.zksync.io/tx/0xc6051b03070892158167bef71469beb435f1f3b60276465285c956a1e5682705

@GitGuru7 GitGuru7 merged commit f51c3db into main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

Assignees

@GitGuru7 GitGuru7

Labels
zkSync sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitGuru7 @chechu