[VEN-2741]: Bridge configurations on zksync mainnet #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could add to the same PR the TX (and VIP for bscmainnet) to be executed on the remote networks to configure the trustworthiness relationship with zkSync |
0xSolDev
approved these changes
Aug 28, 2024
web3rover
approved these changes
Aug 28, 2024
chechu
reviewed
Aug 28, 2024
| signature: "setMintCap(address,uint256)", | ||
| params: [XVS_BRIDGE_DEST, XVS_MINT_LIMIT], | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
Don't we have to configure the limits between zkSync and the rest of the networks? I think we have to invoke the following functions on the XVS_BRIDGE_ADMIN_PROXY, for each network:
- setMaxDailyLimit(uint16,uint256)
- setMaxSingleTransactionLimit(uint16,uint256)
- setMaxDailyReceiveLimit(uint16,uint256)
- setMaxSingleReceiveTransactionLimit(uint16,uint256)
There was a problem hiding this comment.
I see these functions were invoked during the deployment. Ignore this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN