Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2725] VIP for XVS bridge on OP Sepolia and Mainnet #371

Merged
merged 28 commits into from
Sep 27, 2024
Merged

[VEN-2725] VIP for XVS bridge on OP Sepolia and Mainnet #371

merged 28 commits into from
Sep 27, 2024
+32,851 −0

Conversation

Debugger022
Copy link
Contributor

Description

Resolves VEN-2725

@Debugger022 Debugger022 self-assigned this Sep 2, 2024
@Debugger022 Debugger022 marked this pull request as ready for review September 3, 2024 08:34
@chechu
Copy link
Member

chechu commented Sep 3, 2024 •
edited
Loading

We need the multisig TX's to be executed on the remote networks, and the VIP to be executed on BNB testnet, as we made for zkSync sepolia (example here)

GitGuru7
GitGuru7 reviewed Sep 4, 2024
View reviewed changes
src/networkAddresses.ts Outdated Show resolved Hide resolved
multisig/proposals/opsepolia/vip-002/index.ts Outdated Show resolved Hide resolved
multisig/proposals/opsepolia/vip-002/index.ts Outdated Show resolved Hide resolved
multisig/proposals/opsepolia/vip-002/index.ts Outdated Show resolved Hide resolved
multisig/proposals/opsepolia/vip-002/index.ts Outdated Show resolved Hide resolved
multisig/proposals/opsepolia/vip-002/index.ts Outdated Show resolved Hide resolved
@Debugger022
Copy link
Contributor Author

Debugger022 commented Sep 13, 2024 •
edited
Loading

OPsepolia tx: https://sepolia-optimism.etherscan.io/tx/0xa66508379cfdcd53ea3c375d16fdb330774a377c977b54b27b6abf01853105ff

chechu
chechu reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testnet VIP/TX lgtm

@Debugger022
Copy link
Contributor Author

Multisig txs:

Arbitrum sepolia: https://sepolia.arbiscan.io/tx/0x444a13bb434d136b7c496d4331577264c05febccf89c704349406110febe7328

Opbnb testnet: https://testnet.opbnbscan.com/tx/0xc453b99bfbe7880b1e4951563fc15f80bc17a86c90470e31474784c0fb604107

Sepolia testnet: https://sepolia.etherscan.io/tx/0xd4b3d25e98d72bd32a36f6b430c81d460d0745716d57f9a90feebe447e6ce99a

BSC testnet VIP proposal:
https://testnet.bscscan.com/tx/0x4f678cd8de8fea701249b349a1b9102a5350ccd123e43e58eaa4a90e91df804a

VIP: https://venus-testnet.vercel.app/#/governance/proposal/432?chainId=97

@chechu chechu changed the title [VEN-2725] VIP for XVS bridge on OP Sepolia [VEN-2725] VIP for XVS bridge on OP Sepolia and Mainnet Sep 19, 2024
@chechu
Copy link
Member

chechu commented Sep 19, 2024

TX on zkSync sepolia should be executed

@GitGuru7
Copy link
Contributor

Zksync sepolia tx: https://sepolia.explorer.zksync.io/tx/0x2358dd6fe4a9fb41e1152eafae63b9805bdf6b70496e535ed5d12236fee5ad05

chechu
chechu reviewed Sep 25, 2024
View reviewed changes
multisig/simulations/opmainnet/vip-001/index.ts Outdated Show resolved Hide resolved
src/multisig/utils.ts Outdated Show resolved Hide resolved
vips/vip-364/bscmainnet.ts Outdated Show resolved Hide resolved
vips/vip-364/bscmainnet.ts Outdated Show resolved Hide resolved
multisig/simulations/arbitrumone/vip-014/index.ts Outdated Show resolved Hide resolved
multisig/simulations/zksyncmainnet/vip-010/index.ts Outdated Show resolved Hide resolved
multisig/simulations/zksyncsepolia/vip-010/index.ts Outdated Show resolved Hide resolved
chechu
chechu reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands on mainnet TX and VIP lgtm

chechu
chechu reviewed Sep 26, 2024
View reviewed changes
multisig/proposals/opbnbmainnet/vip-022/index.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be renamed to 018

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should identify and remove the 4 txs that weren't executed and shift all the remaining opbnbmainnet txs by 4, I think it's better to do it in a separate PR

@chechu
Copy link
Member

chechu commented Sep 26, 2024

https://app.venus.io/#/governance/proposal/374?chainId=56

@chechu chechu merged commit b63bf3d into main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

@kkirka kkirka Awaiting requested review from kkirka

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@Debugger022 Debugger022

Labels
OP mainnet OP sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Debugger022 @chechu @GitGuru7 @kkirka