[VEN-1709]: simulations for adding a new market in DeFi pool #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Jul 17, 2023
chechu
approved these changes
Jul 18, 2023
chechu
approved these changes
Jul 18, 2023
chechu
reviewed
Jul 20, 2023
chechu
reviewed
Jul 20, 2023
chechu
reviewed
Jul 20, 2023
chechu
reviewed
Jul 20, 2023
GitGuru7
changed the title
chechu
approved these changes
Jul 20, 2023
kkirka
approved these changes
Jul 24, 2023
|
|
||
| it("should set vankrBNB_DeFi collateral factor to 0", async () => { | ||
| const market = await comptroller.markets(vankrBNB_DeFi); | ||
| expect(market.collateralFactorMantissa).to.equal(parseUnits("0", 18)); |
There was a problem hiding this comment.
Suggested change
| expect(market.collateralFactorMantissa).to.equal(parseUnits("0", 18)); | |
| expect(market.collateralFactorMantissa).to.equal(0); |
|
|
||
| it("should set vankrBNB_DeFi liquidation threshold to 0", async () => { | ||
| const market = await comptroller.markets(vankrBNB_DeFi); | ||
| expect(market.liquidationThresholdMantissa).to.equal(parseUnits("0", 18)); |
There was a problem hiding this comment.
Suggested change
| expect(market.liquidationThresholdMantissa).to.equal(parseUnits("0", 18)); | |
| expect(market.liquidationThresholdMantissa).to.equal(0); |
| const comptroller = await ethers.getContractAt(COMPTROLLER_ABI, COMPTROLLER_DeFi); | ||
| expect(await comptroller.getRewardDistributors()).to.have.lengthOf(2); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Suggested change
| it("should be added to DeFi pool", async () => { | |
| expect(await comptroller.getRewardDistributors()).to.include(REWARD_DISTRIBUTOR); | |
| }); | |
|
|
||
| describe("Reward Distributor", () => { | ||
| it("should have 2 rewards distributor in DeFi pool", async () => { | ||
| const comptroller = await ethers.getContractAt(COMPTROLLER_ABI, COMPTROLLER_DeFi); |
There was a problem hiding this comment.
We have comptroller defined already, so no need to redefine AFAIU
Suggested change
| const comptroller = await ethers.getContractAt(COMPTROLLER_ABI, COMPTROLLER_DeFi); |
chechu
approved these changes
Jul 24, 2023
chechu
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN-1709