Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-1734] SD Price Feed #43

Merged
merged 4 commits into from
Jul 20, 2023
Merged

[VEN-1734] SD Price Feed #43

merged 4 commits into from
Jul 20, 2023

Conversation

web3rover
Copy link
Contributor

Description

Resolves VEN

@web3rover web3rover marked this pull request as ready for review July 18, 2023 17:01
@web3rover web3rover requested a review from chechu July 18, 2023 17:01
chechu
chechu approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VIP for testnet lgtm. We can integrated the changes to mainnet in the VIP upgrading the Oracles (#38)

@web3rover
Copy link
Contributor Author

The VIP for testnet lgtm. We can integrated the changes to mainnet in the VIP upgrading the Oracles (#38)

Done. I have combined the mainnet VIPs

@web3rover web3rover merged commit 1367b51 into develop Jul 20, 2023
1 of 2 checks passed
@web3rover web3rover mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web3rover @chechu