Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/playwright-community/playwright-go from 0.2000.1 to 0.3500.0 #1087

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023

Bumps github.com/playwright-community/playwright-go from 0.2000.1 to 0.3500.0.

Release notes

Sourced from github.com/playwright-community/playwright-go's releases.

v0.3500.0

This version is on pair driver-wise with the Playwright 1.35 version.

The release would not have been possible without @​canstand, thanks a ton to him! 💯

Breaking change:

Locators now return no error anymore.

// before
l, err := page.Locator("body")
assertNil(t, err)
d, err := l.Locator("div")
assertNil(t, err)
// ...
// after
_, err := page.Locator("body").Locator("div").And("p").TextContent()
assertNil(t, err)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/playwright-community/playwright-go](https://github.com/playwright-community/playwright-go) from 0.2000.1 to 0.3500.0.
- [Release notes](https://github.com/playwright-community/playwright-go/releases)
- [Commits](playwright-community/playwright-go@v0.2000.1...v0.3500.0)

---
updated-dependencies:
- dependency-name: github.com/playwright-community/playwright-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 3, 2023

The following labels could not be found: type: dependencies.

Copy link
Member

@mapkon mapkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gliptak The playwright.Page interface has deviated and is causing some tests to fail. Do you have an idea how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #1087 (f1be86d) into master (f5f7ed0) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
- Coverage   36.32%   36.20%   -0.12%     
==========================================
  Files          53       53              
  Lines        7951     7951              
==========================================
- Hits         2888     2879       -9     
- Misses       4690     4703      +13     
+ Partials      373      369       -4     
Flag Coverage Δ
unittests 36.20% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/provider/browser/browser.go 44.00% <0.00%> (-12.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gliptak
Copy link
Contributor

gliptak commented Jul 19, 2023

build is green. was this an intermittent issue?

@mapkon
Copy link
Member

mapkon commented Jul 19, 2023

I had to delete the test - please check the commits. Not sure this is something we can easily fix

@mapkon mapkon merged commit c383c16 into master Jul 21, 2023
8 checks passed
@mapkon mapkon deleted the dependabot/go_modules/github.com/playwright-community/playwright-go-0.3500.0 branch July 21, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants