Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleApps: add a simple message so the user knows he must set-up 2 step verification #1096

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

brenol
Copy link
Contributor

@brenol brenol commented Jul 18, 2023

fixes #1094

@codecov-commenter
Copy link

Codecov Report

Merging #1096 (4c117c0) into master (7e4ff84) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   36.30%   36.32%   +0.01%     
==========================================
  Files          53       53              
  Lines        7943     7951       +8     
==========================================
+ Hits         2884     2888       +4     
- Misses       4686     4690       +4     
  Partials      373      373              
Flag Coverage Δ
unittests 36.32% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/provider/googleapps/googleapps.go 26.10% <50.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mapkon mapkon merged commit f5f7ed0 into Versent:master Jul 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error authenticating to IdP.: page is missing saml assertion because of missing 2-Step verification setting
3 participants