Print swipe number for PingFederate

[silver886]

Print swipe number if there is div.numbermatching in swipe page.

Fix #1114

[codecov-commenter]

Codecov Report

Merging #1115 (88ffb4c) into master (7f8e7d4) will increase coverage by 0.31%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   36.20%   36.52%   +0.31%     
==========================================
  Files          53       53              
  Lines        7951     7954       +3     
==========================================
+ Hits         2879     2905      +26     
+ Misses       4703     4675      -28     
- Partials      369      374       +5     

Flag	Coverage Δ
unittests	36.52% <100.00%> (+0.31%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/provider/pingfed/pingfed.go	34.13% <100.00%> (+12.18%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[silver886]

@mapkon could we have this merged and released?
I also took a look at #877 and added unit test for it.

[mapkon]

@mapkon could we have this merged and released? I also took a look at #877 and added unit test for it.

@silver886 Yes, that can be arranged. However, not with a decreased test coverage as it is now. You will have to bump that coverage up.

[silver886]

That's interesting.
TestHandleSwipe is added and should increase the coverage. 🤔

[mapkon]

That's interesting. TestHandleSwipe is added and should increase the coverage. 🤔

The Test coverage report is above. Please check it out

[silver886]

I checked, and the report said it increases the coverage by 0.31%.
And Codecov, https://app.codecov.io/gh/Versent/saml2aws/commit/46cab7e270159126a0ebd000906ed9a051a49d1e, also shows the same results.

[mapkon]

I checked, and the report said it increases the coverage by 0.31%. And Codecov, https://app.codecov.io/gh/Versent/saml2aws/commit/46cab7e270159126a0ebd000906ed9a051a49d1e, also shows the same results.

lol! I was referencing a cached version. My bad. I will take another look.

[steven130169]

I need this feature, please release it. Thanks.

[mapkon]

I need this feature, please release it. Thanks.

I am on it - been slightly busy

[mapkon]

I have cut the v2.36.11 Release