-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for Support Number Challenge for Okta MFA (#877) #1116
Unit test for Support Number Challenge for Okta MFA (#877) #1116
Conversation
This PR won't pass unit test unless #877 is in place. |
@silver886 The tests are failing on this one. |
Yeah, because the actual code that implements the feature is #877. Should I copy @muramasa64 's code into this PR? |
Yeah - and probably close that PR since it will no longer be required. |
This reverts commit 52c44b2.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 36.52% 37.19% +0.66%
==========================================
Files 53 53
Lines 7954 7959 +5
==========================================
+ Hits 2905 2960 +55
+ Misses 4675 4619 -56
- Partials 374 380 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Unit test for #877.
#877 (comment)
#877 (comment)