Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for Support Number Challenge for Okta MFA (#877) #1116

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

silver886
Copy link
Contributor

@silver886 silver886 commented Aug 25, 2023

@silver886
Copy link
Contributor Author

This PR won't pass unit test unless #877 is in place.

@mapkon
Copy link
Member

mapkon commented Aug 26, 2023

@silver886 The tests are failing on this one.

@silver886
Copy link
Contributor Author

Yeah, because the actual code that implements the feature is #877.

Should I copy @muramasa64 's code into this PR?

@mapkon
Copy link
Member

mapkon commented Aug 26, 2023

Yeah, because the actual code that implements the feature is #877.

Should I copy @muramasa64 's code into this PR?

Yeah - and probably close that PR since it will no longer be required.

@codecov-commenter
Copy link

Codecov Report

Merging #1116 (edf7c38) into master (b63aed1) will increase coverage by 0.66%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   36.52%   37.19%   +0.66%     
==========================================
  Files          53       53              
  Lines        7954     7959       +5     
==========================================
+ Hits         2905     2960      +55     
+ Misses       4675     4619      -56     
- Partials      374      380       +6     
Flag Coverage Δ
unittests 37.19% <100.00%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/provider/okta/okta.go 26.52% <100.00%> (+4.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mapkon mapkon merged commit 068b527 into Versent:master Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants