Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/playwright-community/playwright-go from 0.3500.0 to 0.3700.0 #1122

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2023

Bumps github.com/playwright-community/playwright-go from 0.3500.0 to 0.3700.0.

Release notes

Sourced from github.com/playwright-community/playwright-go's releases.

v0.3700.0

This version is on pair driver-wise with the Playwright 1.37 version.

BREAKING CHANGE:

Due to the rewrite of the go code generation scripts, it brings a lot of changes. Note the following 4 types:

  1. Links and Deprecated tags in Go doc comments now work.
    • May cause many Deprecated lint errors, please update the call or use //nolint:staticcheck to ignore.
  2. Added event interface methods. For example WebSocket.OnFrameReceived() etc.
    // before
    websocket.On("framereceived", ...)
    // after
    websocket.OnFrameReceived(...)
  3. The signatures of some interface methods have changed, for example:
    • Unified optional parameter naming. For example, previously all Click used PageClickOptions, now
      Locator.Click(options ...LocatorClickOptions)
      Page.Click(selector string, options ...PageClickOptions)
      Frame.Click(selector string, options ...FrameClickOptions)
    • Some parameters are generated as new types or names, e.g. Page.AddInitScript(script Script)
  4. Removed several methods that were not documented upstream. These methods can be safely converted to other existing methods. For example
    • Page.ExpectedDialog can use Page.OnDialog instead.
    • All xxxAssertions.NotTo..., use .Not().xxx pls.
    • WebSocket.On("framesent", ...), use WebSocket.OnFrameSent(...).

New Contributors

Full Changelog: playwright-community/playwright-go@v0.3500.0...v0.3700.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/playwright-community/playwright-go](https://github.com/playwright-community/playwright-go) from 0.3500.0 to 0.3700.0.
- [Release notes](https://github.com/playwright-community/playwright-go/releases)
- [Commits](playwright-community/playwright-go@v0.3500.0...v0.3700.0)

---
updated-dependencies:
- dependency-name: github.com/playwright-community/playwright-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2023

The following labels could not be found: type: dependencies.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 16, 2023

A newer version of github.com/playwright-community/playwright-go exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@mapkon
Copy link
Contributor

mapkon commented Nov 3, 2023

@gliptak Do you have any insight into why this is failing? I am struggling to nail it down (as to why Page has the wrong interface). Might be my limited knowledge of go-lang?

@gliptak
Copy link
Contributor

gliptak commented Nov 3, 2023

@mapkon
Copy link
Contributor

mapkon commented Nov 4, 2023

Maybe related to https://github.com/playwright-community/playwright-go/releases/tag/v0.3700.0?

https://github.com/Versent/saml2aws/tree/master/mocks might need to regenerated

#992

Any idea how to regenerate the mocks?

@mapkon
Copy link
Contributor

mapkon commented Nov 5, 2023

Ref: #1157

@mapkon mapkon closed this Nov 5, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/playwright-community/playwright-go-0.3700.0 branch November 5, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants