Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hacky way to get to the challenge #1277

Closed
wants to merge 4 commits into from

Conversation

codingtony-candid
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0.81633% with 243 lines in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (54e1e97) to head (4d2c359).
Report is 5 commits behind head on master.

Files Patch % Lines
pkg/provider/googleapps/googleapps.go 0.81% 243 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   42.08%   41.01%   -1.08%     
==========================================
  Files          54       54              
  Lines        6442     6615     +173     
==========================================
+ Hits         2711     2713       +2     
- Misses       3288     3459     +171     
  Partials      443      443              
Flag Coverage Δ
unittests 41.01% <0.81%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon
Copy link
Contributor

mapkon commented Jun 4, 2024

What is the essence of this PR?

@codingtony-candid
Copy link
Author

An attempt to fix issue 1259

@codingtony-candid
Copy link
Author

We can close it, I'll work on a branch until it's ready for review.

@mapkon
Copy link
Contributor

mapkon commented Jun 5, 2024

OK - let me know when its ready.

@mapkon mapkon closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants