AWS partitions support for saml2aws console

[duckfez]

Fixes #533.

Adds support for saml2aws console to use region= in config file
as a hint for which partition to open the console in.

[duckfez]

I am a little concerned about littering the codebase with special cases for GovCloud and AWS China. But, I don't have the experience with the codebase (or golang itself tbh) to attempt a more comprehensive refactor.

[mapkon]

@duckfez Are you still interested in getting this merged? If yes, please fix the conflicts and check if the code coverage is fine. If not, we can close the PR

[gliptak]

Okta provider already has special cases

saml2aws/pkg/provider/okta/okta.go

Lines 652 to 654 in 1c3449a

	urls = []string{"form[action=\"https://signin.aws.amazon.com/saml\"]",
	"form[action=\"https://signin.amazonaws-us-gov.com/saml\"]",
	"form[action=\"https://signin.amazonaws.cn/saml\"]",

[duckfez]

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

[mapkon]

I don't mind rebasing this against current main, but I no longer have access to test in GovCloud. The underlying issue #533 has not seen a lot of support for this problem, so maybe it's not worth it? Maybe one of the other interested folks in that issue can help with testing?

Thanks for the response! Let us start by rebasing it to main.

[mapkon]

@duckfez Any traction on this?