Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Color Grading with OpenGL backend (by @vantaboard) #1059

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Fix Color Grading with OpenGL backend (by @vantaboard) #1059

merged 1 commit into from
Sep 30, 2023

Conversation

Xaymar
Copy link
Contributor

@Xaymar Xaymar commented Jul 28, 2023

Explain the Pull Request

Fixes ambiguous log() calls in OpenGL. Really need to switch to a proper shader transpiler.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@vantaboard
fix: add decimal place to remove ambiguity
cbc67c3 
error: Error compiling shader:
0(142) : error C1101: ambiguous overloaded function reference "log(int)"
    (0) : lowp float log(lowp float)
    (0) : mediump float log(mediump float)
    (0) : float log(float)

error: device_pixelshader_create (GL) failed
error: Pass (0) <> missing pixel shader!
error: [StreamFX] <filter::color_grade> Error loading '/usr/local/share/obs/obs-plugins/StreamFX/effects/color-grade.effect': Unknown error during effect compile.
error: [StreamFX] Unexpected exception in function '_create': Unknown error during effect compile..
error: Failed to create source 'Color Grading'!
@Xaymar Xaymar merged commit cfcf975 into Vhonowslend:root Sep 30, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Color Grading (Component, Filter)
Development

Successfully merging this pull request may close these issues.
2 participants
@Xaymar @vantaboard