Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ability to override namespace #1395

Merged
merged 4 commits into from
Sep 3, 2024
Merged

added ability to override namespace #1395

merged 4 commits into from
Sep 3, 2024

Conversation

AndrewChubatiuk
Copy link
Collaborator

fixes #569

@github-actions github-actions bot added k8s-stack k8s-stack helm chart related issue agent vmagent helm chart related issue alert vmalert helm chart related issue auth vmauth helm chart related issue cluster vmcluster helm chart related issue operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue anomaly vmanomaly logs-single labels Sep 2, 2024
f41gh7
f41gh7 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk merged commit 566e979 into master Sep 3, 2024
36 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the ns-override branch September 3, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue alert vmalert helm chart related issue anomaly vmanomaly auth vmauth helm chart related issue cluster vmcluster helm chart related issue k8s-stack k8s-stack helm chart related issue logs-single operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override namespace through values.yaml
2 participants
@AndrewChubatiuk @f41gh7