Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: use <appSection>.fullnameOverride as alternative source for resource name prefix #1595

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

AndrewChubatiuk
Copy link
Collaborator

currenly default name prefix override can be extracted from:

  • global.fullnameOverride
  • global.<Chart.Name>.fullnameOverride:
  • fullnameOverride
  • .name

Added <appSection>.fullnameOverride additionally to fix backward compatibility issue for cluster chart

@github-actions github-actions bot added the k8s-stack k8s-stack helm chart related issue label Oct 15, 2024
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit 250dbe7 into master Oct 15, 2024
8 checks passed
@f41gh7 f41gh7 deleted the common-app-fullname-override branch October 15, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s-stack k8s-stack helm chart related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants