Address several drawing issues with Xcode 15 #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Views no clip to their bounds anymore, which allows views to draw outside of their bounds. In the browser UI, the RSS, cancel and reload buttons are hidden by setting layout constraints to zero (`updateAddressBarButtons()` in BrowserTab+Interface.swift). This causes the button icons to still be visible. This is addressed by enabling the `clipsToBounds` property in Interface Builder, which should be fully backwards compatible. For the EnclosureView, the drawing is restricted to the view's `bounds` instead of `dirtyRect`.
barijaona
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the drawing issues I found so far and mentioned in #1707. There could be more.
In the browser UI, the RSS, cancel and reload buttons are hidden by setting layout constraints to zero (
updateAddressBarButtons()in BrowserTab+Interface.swift). This causes the button icons to still be visible. This is addressed by enabling theclipsToBoundsproperty in Interface Builder, which should be fully backwards compatible.For the EnclosureView, the drawing is restricted to the view's
boundsinstead ofdirtyRect.