Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle command-click and option-click on links #1803

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Handle command-click and option-click on links #1803

merged 5 commits into from
Aug 31, 2024

Commits on Aug 28, 2024

  1. Remove unused code

    @barijaona
    barijaona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d75435b View commit details
    Browse the repository at this point in the history

  2. Add createNewTabAfterSelected to Browser protocol

    @barijaona
    barijaona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    59d592c View commit details
    Browse the repository at this point in the history

  3. Handle command-click on links in browser tabs 

    Make command-click on a link in a browser tab to open a new tab, like in
other major web browsers.
Also have option-click in a browser tab behave the same way as an option
-click in the primary tab : open the link in the browser which is not
set as the default in General settings (either it is the system's default
browser or Vienna's internal browser).

Solves request expressed in discussion ViennaRSS#1740
    @barijaona
    barijaona committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d88251c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Add @discardableResult attribute to functions 

    Co-authored-by: Eitot <[email protected]>
    @barijaona @Eitot
    barijaona and Eitot committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    abbe031 View commit details
    Browse the repository at this point in the history

  2. Remove unused code 

    Co-authored-by: Eitot <[email protected]>
    @barijaona @Eitot
    barijaona and Eitot committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    5e0ab1f View commit details
    Browse the repository at this point in the history