Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202405 UI update #514

Merged
merged 5 commits into from
Jun 21, 2024
Merged

202405 UI update #514

merged 5 commits into from
Jun 21, 2024

Conversation

AaronCohen21
Copy link
Member

@AaronCohen21 AaronCohen21 commented Mar 5, 2024

Description

Add summer 2024 term to banner and dropdown. Also updated gitignore to recognize node_modules folder in other directories (for the re-write)

Screenshots

Before

Screenshot from 2024-03-04 19-19-47

After

Screenshot from 2024-03-04 19-19-25

Checklist

  • The code follows all style guidelines.
  • The code passes all required tests.
  • The code is documented.
  • The code includes tests.
  • I have self-reviewed my changes and have done QA.

General Comments

@AaronCohen21 AaronCohen21 requested a review from a team as a code owner March 5, 2024 03:18
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
courseup ❌ Failed (Inspect) Jun 21, 2024 2:05am

Copy link
Contributor

@JoshoTheMosho JoshoTheMosho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail removing 202305

  • src/common/header/components/__tests__/TermSelect.test.tsx
  • src/pages/calendar/components/__tests__/Requisites.test.tsx

Also I'm unsure how crucial adding 202405 to these ones is, but might want to check out:

  • constants.ts
  • fetchers.tsx

Copy link
Contributor

@JoshoTheMosho JoshoTheMosho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pray we can get this working again 🙏

@AaronCohen21 AaronCohen21 merged commit 2ece3c7 into main Jun 21, 2024
10 of 12 checks passed
@AaronCohen21 AaronCohen21 deleted the aaron/202405-ui-update branch June 21, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants