Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor attribute fix #79

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Minor attribute fix #79

merged 4 commits into from
Nov 8, 2024

Conversation

Vindaar
Copy link
Owner

@Vindaar Vindaar commented Nov 8, 2024

Just a couple of minor fixes for some gotchas when reading attributes. Both [] taking a string (returning a data type kind) and withAttr would previously fail, if the attribute hadn't been read at all. Now we make sure to actually check in the file first.

* v0.6.3
- make ~[]~ for attributes taking a string only for the data type kind
  to check if the key exist, raise if not.
  Previously if the attribute hadn't been opened before, the call
  would fail even if it exists in the file
- make ~withAttr~ check if the attribute exists in the file
  first. Previously would fail if it hadn't been opened before

@Vindaar Vindaar merged commit ea6525a into master Nov 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant