This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Amélioration de l'UI de notre design system (storybook) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m documentation ✨ feat(.storybook): add custom theme to Storybook manager UI 📦 chore(package.json): add @storybook/theming package as a dependency The meta tags and styles added to the manager-head.html file improve the design system documentation by providing a more complete and consistent experience for users. The custom theme added to the Storybook manager UI improves the branding and visual consistency of the design system. The @storybook/theming package is added as a dependency to enable the use of custom themes in Storybook.
Bluzzi
approved these changes
Jun 26, 2023
.storybook/theme.ts
Outdated
| appBorderColor: "#1E1E1F", | ||
| appBorderRadius: 4, | ||
|
|
||
| // Toolbar colors : |
There was a problem hiding this comment.
En anglais les : sont collés ! :p
.storybook/manager-head.html
Outdated
Comment on lines
1
to
4
| <meta name="description" content="Le système de conception du Royaume offre une expérience utilisateur cohérente et esthétique à travers notre site internet, grâce à des principes, composants et directives de conception réutilisables."> | ||
|
|
||
| <meta name="og:title" content="Système de conception du Royaume"> | ||
| <meta name="og:description" content="Le système de conception du Royaume offre une expérience utilisateur cohérente et esthétique à travers notre site internet, grâce à des principes, composants et directives de conception réutilisables."> |
There was a problem hiding this comment.
Je pense qu'il est mieux d'utiliser le therme "Design System" même en français !
The meta tags in the `.storybook/manager-head.html` file have been updated to reflect the correct name of the design system, which is "Design system du Royaume" in French. The `theme.ts` file has been updated to improve the readability of the comments by removing unnecessary spaces and adding a colon after the section titles. No functional changes have been made.
🚚 chore(.storybook/theme.ts): import create from @storybook/theming instead of @storybook/theming/create The storybook-static directory is no longer being ignored as it is now required to be tracked in the repository. The import statement in the theme.ts file has been updated to import the create function from the @storybook/theming package instead of @storybook/theming/create. This is because the create function has been moved to the root of the package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.