Merge pull request #142 from VirtualPhotonics/feature/139-address-dep…

…recation-warning-when-building-vts-under-net-v6 feature/139-address-deprecation-warning-when-building-vts-under-net-v6
VirtualPhotonics · Apr 26, 2024 · 53b0743 · 53b0743
2 parents a210cda + a6e7f73
commit 53b0743
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 22 deletions.
diff --git a/src/Vts/IO/BinaryArraySerializer.cs b/src/Vts/IO/BinaryArraySerializer.cs
@@ -8,11 +8,6 @@ namespace Vts.IO
     /// </summary>
     public class BinaryArraySerializer
     {
-        /// <summary>
-        /// array to be written or read
-        /// </summary>
-        [Obsolete("The Serialization reconfiguration made this property obsolete.")]
-        public Array DataArray { get; set; }
         /// <summary>
         /// name of array
         /// </summary>
@@ -21,12 +16,6 @@ public class BinaryArraySerializer
         /// file tag string
         /// </summary>
         public string FileTag { get; set; }
-        /// <summary>
-        /// dimensions of array
-        /// </summary>
-        [Obsolete("Property was never used by the code and will be removed.")]
-        public int[] Dimensions { get; set; }
-
         /// <summary>
         /// method to write data
         /// </summary>

diff --git a/src/Vts/MonteCarlo/Helpers/SourceDefaults.cs b/src/Vts/MonteCarlo/Helpers/SourceDefaults.cs
@@ -22,11 +22,6 @@ public static class SourceDefaults
         /// </summary>
         public static PolarAzimuthalAngles DefaultBeamRotationFromInwardNormal => new PolarAzimuthalAngles(0.0, 0.0);
         /// <summary>
-        /// Default beam rotation angle from inward normal (0.0, 0.0)
-        /// </summary>
-        [Obsolete("DefaultBeamRoationFromInwardNormal is deprecated, please use DefaultBeamRotationFromInwardNormal instead.")]
-        public static PolarAzimuthalAngles DefaultBeamRoationFromInwardNormal => new PolarAzimuthalAngles(0.0, 0.0);
-        /// <summary>
         /// Default full polar angle range (0.0, PI)
         /// </summary>
         public static DoubleRange DefaultFullPolarAngleRange => new DoubleRange(0, Math.PI);

diff --git a/src/Vts/Range/RangeOfT.cs b/src/Vts/Range/RangeOfT.cs
@@ -119,10 +119,10 @@ public int Count
         /// <returns>A string that represents the current range</returns>
         public override string ToString()
         {
-            return "Start: " + Start.ToString() + 
-                 ", Stop: " + Stop.ToString() + 
-                 ", Count: " + Count.ToString() + 
-                 ", Delta: " + Delta.ToString();
+            return "Start: " + Start + 
+                 ", Stop: " + Stop + 
+                 ", Count: " + Count + 
+                 ", Delta: " + Delta;
         }
 
         /// <summary>
@@ -141,8 +141,7 @@ public override string ToString()
         /// Returns an IEnumerable of type T that enumerates the range
         /// </summary>
         /// <returns>An IEnumerable of type T that enumerates the range</returns>
-        [Obsolete("This method is deprecated. Use built-in IEnumerable implementation instead.")]
-        public IEnumerable<T> AsEnumerable()
+        private IEnumerable<T> AsEnumerable()
         {
             var increment = GetIncrement();