Hopefully cleaned up issue of unreachable code path and of using type…

… in "out" parameter since interface defines type.
VirtualPhotonics · Feb 22, 2024 · 8f73dac · 8f73dac
1 parent 183b53c
commit 8f73dac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/Vts/MonteCarlo/Helpers/CylinderTissueRegionToolbox.cs b/src/Vts/MonteCarlo/Helpers/CylinderTissueRegionToolbox.cs
@@ -115,11 +115,10 @@ public static bool RayIntersectInfiniteCylinder(Position p1, Position p2, bool o
 
                     return true;
 
+                default:     // roots imaginary -> no intersection 
+                    return false;
             } /* end switch */
 
-            /* bb-4ac>0 */
-            /* roots imaginary -> no intersection */
-            return false;
         }  
     }
 }
diff --git a/src/Vts/MonteCarlo/Tissues/SingleInclusionTissue.cs b/src/Vts/MonteCarlo/Tissues/SingleInclusionTissue.cs
@@ -93,8 +93,7 @@ public override double GetDistanceToBoundary(Photon photon)
             if ((regionIndex != _layerRegionIndexOfInclusion) && (regionIndex != _inclusionRegionIndex))
                 return base.GetDistanceToBoundary(photon);
             // check if current track will hit the inclusion boundary, returning the correct distance
-            double distanceToBoundary;
-            if (_inclusionRegion.RayIntersectBoundary(photon, out distanceToBoundary))
+            if (_inclusionRegion.RayIntersectBoundary(photon, out var distanceToBoundary))
             {
                 return distanceToBoundary;
             }