Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vts build without matlab implementation #140

Closed
scottprahl opened this issue Apr 16, 2024 · 2 comments · Fixed by #141
Closed

Allow vts build without matlab implementation #140

scottprahl opened this issue Apr 16, 2024 · 2 comments · Fixed by #141
Assignees

Comments

@scottprahl
Copy link

Currently executing

./BuildTestRelease.ps1 

requires a matlab installation. Perhaps the matlab builds could be made optional for those who just want to use vts in a JuptyerLab environment?

@hayakawa16
Copy link
Member

Like this suggestion! We are currently working on python scripts so this comment is right in line with our next steps. We will work on a way to opt in and out of these additional tools.

@hayakawa16 hayakawa16 self-assigned this Apr 17, 2024
@hayakawa16
Copy link
Member

I have determined command to check if matlab is installed or not. I thought I could just edit BuildTestRelease and check before command to Invoke BuildTestReleaseMATLAB, however matlab is also invoked in BuildTestReleaseMCCL. So I added the same if check before that call. I have tried updated code on:

  1. windows with matlab installed
  2. linux with matlab installed
  3. linux with no matlab available
    and these run as they should.
    I have pushed these changes to the branch associated with this issue and will create a PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants