Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check if Matlab installed before running powershell commands that rely on its installation. #141

Merged

Conversation

hayakawa16
Copy link
Member

I added powershell commands in BuildTestRelease.ps1 and BuildTestReleaseMCCL.ps1 to check if Matlab is installed and if not to not run any commands that rely on its installation.

@hayakawa16 hayakawa16 linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@lmalenfant lmalenfant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hayakawa16 hayakawa16 merged commit a210cda into master Apr 19, 2024
2 checks passed
@hayakawa16 hayakawa16 deleted the feature/140-allow-vts-build-without-matlab-implementation branch April 19, 2024 20:43
@janakarana
Copy link
Member

I ran the latest build on my Mac. This is to confirm that the bug at the end is now fixed.

@hayakawa16
Copy link
Member Author

Thanks @janakarana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow vts build without matlab implementation
3 participants