-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/112 reconfigure the detectors to use global code for the binary serializers 2 #129
Feature/112 reconfigure the detectors to use global code for the binary serializers 2 #129
Commits on Oct 31, 2023
-
Update detector serialization to use the new BinaryArraySerializer code
Lisa Malenfant committedOct 31, 2023 Configuration menu - View commit details
-
Copy full SHA for 689e6eb - Browse repository at this point
Copy the full SHA 689e6ebView commit details
Commits on Nov 1, 2023
-
Modified int[] to var in BinaryArraySerializer. Added BinaryArraySeri…
…alizer code in more detectors. All unit tests pass.
Configuration menu - View commit details
-
Copy full SHA for 86841b7 - Browse repository at this point
Copy the full SHA 86841b7View commit details -
BuildTestRelease.ps1 outed some errors in implementation of extra bin…
…ary files (other than Mean and SecondMoment) and file tag.
Configuration menu - View commit details
-
Copy full SHA for 0d24225 - Browse repository at this point
Copy the full SHA 0d24225View commit details -
Configuration menu - View commit details
-
Copy full SHA for d496f39 - Browse repository at this point
Copy the full SHA d496f39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc47ce - Browse repository at this point
Copy the full SHA 0fc47ceView commit details
Commits on Nov 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f5cf1e6 - Browse repository at this point
Copy the full SHA f5cf1e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff06fe4 - Browse repository at this point
Copy the full SHA ff06fe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a77e491 - Browse repository at this point
Copy the full SHA a77e491View commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 237d0f8 - Browse repository at this point
Copy the full SHA 237d0f8View commit details
Commits on Nov 6, 2023
-
Updated DetectorIOTests to test GetBinarySerializers single layer of …
…binary serialization, rather than testing other code like CreateDetector and DetectorIO.WriteDetectorToFile, etc. Also needed to modify the code in the MT detectors to not check for TallySecondMoment to define SecondMoment array. Otherwise SecondMoment array was not in the serlalizers list in WriteClearAndReReadArrays in DetectorBinarySerializerHelper. Only 18 detectors currently in DetectorIOTests, need to add 54 more tests.
Configuration menu - View commit details
-
Copy full SHA for 30dbfbb - Browse repository at this point
Copy the full SHA 30dbfbbView commit details -
In GetBinarySerializers, added back in check on if (TallySecondMoment…
…) is true before allocation of SecondMoment arrays.
Configuration menu - View commit details
-
Copy full SHA for c2f7a0b - Browse repository at this point
Copy the full SHA c2f7a0bView commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 82f333f - Browse repository at this point
Copy the full SHA 82f333fView commit details -
Added xml comments to DetectorBinarySerializationHelper. Added more u…
…nit tests. List of cleanup files is not complete yet.
Configuration menu - View commit details
-
Copy full SHA for ffaa48f - Browse repository at this point
Copy the full SHA ffaa48fView commit details
Commits on Nov 8, 2023
-
Renamed new tests to DetectorBinarySerializationTests (for now, will …
…get separated into separate detector test classes) and brought back original DetectorIOTests. Attempted modifying ATotalDetector to return an empy array rather than null.
Configuration menu - View commit details
-
Copy full SHA for 7a078de - Browse repository at this point
Copy the full SHA 7a078deView commit details -
Added more DetectorBinarySerializer tests and rearranged file so that…
… alphabetical within a dimension. Made an attempt at ATotalDetector test, but need to ask the senior coders.
Configuration menu - View commit details
-
Copy full SHA for 94d3f9a - Browse repository at this point
Copy the full SHA 94d3f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d70e81b - Browse repository at this point
Copy the full SHA d70e81bView commit details
Commits on Nov 9, 2023
-
Modified single value detectors to return an empty array rather than …
…null and updated unit tests in DetectorBinarySerializationTests. Added new tests. Updated the independent variable Counts to be consistent with array Mean specification (it doesn't matter regarding the test, the counts could be anything) but just to not add confusion. So if Mean[2,3] then initialized using {{ 1, 2, 3}, { 4, 5, 6}}.
Configuration menu - View commit details
-
Copy full SHA for ada97e3 - Browse repository at this point
Copy the full SHA ada97e3View commit details -
Added unit tests for BinaryArraySerializerFactory
Lisa Malenfant committedNov 9, 2023 Configuration menu - View commit details
-
Copy full SHA for bce36f5 - Browse repository at this point
Copy the full SHA bce36f5View commit details -
Merge pull request #128 from VirtualPhotonics/feature/add-tests-112-r…
…econfigure-the-detectors-to-use-global-code-for-the-binary-serializers_2 Added unit tests for BinaryArraySerializerFactory
Lisa Malenfant authoredNov 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 3e0e74f - Browse repository at this point
Copy the full SHA 3e0e74fView commit details
Commits on Nov 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1a7ba7e - Browse repository at this point
Copy the full SHA 1a7ba7eView commit details -
Added more documentation to the tests so that reader can tell dimensi…
…ons the arrays would be if the user instantiated them with the specified independent variables.
Configuration menu - View commit details
-
Copy full SHA for cf3e0c3 - Browse repository at this point
Copy the full SHA cf3e0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7f6fc8 - Browse repository at this point
Copy the full SHA a7f6fc8View commit details -
Found that several detectors GetBinarySerialization code did not chec…
…k for TallySecondMoment before allocating SecondMoment array. Fixed those. First 5D array test complete and outed this error.
Configuration menu - View commit details
-
Copy full SHA for 82e0f0f - Browse repository at this point
Copy the full SHA 82e0f0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef12a2d - Browse repository at this point
Copy the full SHA ef12a2dView commit details
Commits on Nov 13, 2023
-
Finished unit tests for DetectorBinarySerialization in all detectors.…
… Need to try toggling TallySecondMoment and test that.
Configuration menu - View commit details
-
Copy full SHA for 9b11460 - Browse repository at this point
Copy the full SHA 9b11460View commit details -
Added ability to test with TallySecondMoment toggle between true and …
…false. Tried to consolodate common code more, but don't think I can.
Configuration menu - View commit details
-
Copy full SHA for 6ca00c6 - Browse repository at this point
Copy the full SHA 6ca00c6View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1ebf77f - Browse repository at this point
Copy the full SHA 1ebf77fView commit details -
Single value detectors moved to separate files and placed in Vts.Test…
….Unit.MonteCarlo.Detectors folder and namespace. All unit tests pass.
Configuration menu - View commit details
-
Copy full SHA for 575a9d2 - Browse repository at this point
Copy the full SHA 575a9d2View commit details
Commits on Nov 16, 2023
-
Added OneTimeTearDown attribute to Clear_previously_generated_files m…
…ethod so that it runs at Setup and TestDown.
Configuration menu - View commit details
-
Copy full SHA for 9eb6ad9 - Browse repository at this point
Copy the full SHA 9eb6ad9View commit details
Commits on Nov 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 94cfcd4 - Browse repository at this point
Copy the full SHA 94cfcd4View commit details -
Finished separating 2D detector unit tests into their own files. This…
… is the biggest group. I'm over the hump!
Configuration menu - View commit details
-
Copy full SHA for 6a8335a - Browse repository at this point
Copy the full SHA 6a8335aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 553ab02 - Browse repository at this point
Copy the full SHA 553ab02View commit details -
Finished separating 4D and 5D detectors and removed original Detector…
…BinarySerializationTests that included all of the tests. Now I need to make sure the tests cleanup all generated test files properly.
Configuration menu - View commit details
-
Copy full SHA for 6b92e9e - Browse repository at this point
Copy the full SHA 6b92e9eView commit details -
Merge branch 'master' into feature/112-reconfigure-the-detectors-to-u…
…se-global-code-for-the-binary-serializers_2
Configuration menu - View commit details
-
Copy full SHA for 1b1ddbe - Browse repository at this point
Copy the full SHA 1b1ddbeView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5f4f183 - Browse repository at this point
Copy the full SHA 5f4f183View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e3ab4 - Browse repository at this point
Copy the full SHA c9e3ab4View commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2624f37 - Browse repository at this point
Copy the full SHA 2624f37View commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 24e0b13 - Browse repository at this point
Copy the full SHA 24e0b13View commit details -
One unit test dMCdRORhodMusDetectorTests had wrong detector specified…
… in test. I could tell this by the lack of code-coverage shown for GetBinarySerializers in this detector. Rest indentation fixes or consolidation of array specifications.
Configuration menu - View commit details
-
Copy full SHA for 1e66b63 - Browse repository at this point
Copy the full SHA 1e66b63View commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 452398a - Browse repository at this point
Copy the full SHA 452398aView commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb71fd7 - Browse repository at this point
Copy the full SHA cb71fd7View commit details