Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/112 reconfigure the detectors to use global code for the binary serializers 2 #129

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    689e6eb View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Modified int[] to var in BinaryArraySerializer. Added BinaryArraySeri…

    …alizer code in more detectors. All unit tests pass.
    hayakawa16 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    86841b7 View commit details
    Browse the repository at this point in the history
  2. BuildTestRelease.ps1 outed some errors in implementation of extra bin…

    …ary files (other than Mean and SecondMoment) and file tag.
    hayakawa16 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0d24225 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d496f39 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0fc47ce View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    f5cf1e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff06fe4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a77e491 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    237d0f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Updated DetectorIOTests to test GetBinarySerializers single layer of …

    …binary serialization, rather than testing other code like CreateDetector and DetectorIO.WriteDetectorToFile, etc. Also needed to modify the code in the MT detectors to not check for TallySecondMoment to define SecondMoment array. Otherwise SecondMoment array was not in the serlalizers list in WriteClearAndReReadArrays in DetectorBinarySerializerHelper. Only 18 detectors currently in DetectorIOTests, need to add 54 more tests.
    hayakawa16 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    30dbfbb View commit details
    Browse the repository at this point in the history
  2. In GetBinarySerializers, added back in check on if (TallySecondMoment…

    …) is true before allocation of SecondMoment arrays.
    hayakawa16 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c2f7a0b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    82f333f View commit details
    Browse the repository at this point in the history
  2. Added xml comments to DetectorBinarySerializationHelper. Added more u…

    …nit tests. List of cleanup files is not complete yet.
    hayakawa16 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ffaa48f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Renamed new tests to DetectorBinarySerializationTests (for now, will …

    …get separated into separate detector test classes) and brought back original DetectorIOTests. Attempted modifying ATotalDetector to return an empy array rather than null.
    hayakawa16 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7a078de View commit details
    Browse the repository at this point in the history
  2. Added more DetectorBinarySerializer tests and rearranged file so that…

    … alphabetical within a dimension. Made an attempt at ATotalDetector test, but need to ask the senior coders.
    hayakawa16 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    94d3f9a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d70e81b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Modified single value detectors to return an empty array rather than …

    …null and updated unit tests in DetectorBinarySerializationTests. Added new tests. Updated the independent variable Counts to be consistent with array Mean specification (it doesn't matter regarding the test, the counts could be anything) but just to not add confusion. So if Mean[2,3] then initialized using {{ 1, 2, 3}, { 4, 5, 6}}.
    hayakawa16 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ada97e3 View commit details
    Browse the repository at this point in the history
  2. Added unit tests for BinaryArraySerializerFactory

    Lisa Malenfant committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bce36f5 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #128 from VirtualPhotonics/feature/add-tests-112-r…

    …econfigure-the-detectors-to-use-global-code-for-the-binary-serializers_2
    
    Added unit tests for BinaryArraySerializerFactory
    Lisa Malenfant authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3e0e74f View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Configuration menu
    Copy the full SHA
    1a7ba7e View commit details
    Browse the repository at this point in the history
  2. Added more documentation to the tests so that reader can tell dimensi…

    …ons the arrays would be if the user instantiated them with the specified independent variables.
    hayakawa16 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    cf3e0c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a7f6fc8 View commit details
    Browse the repository at this point in the history
  4. Found that several detectors GetBinarySerialization code did not chec…

    …k for TallySecondMoment before allocating SecondMoment array. Fixed those. First 5D array test complete and outed this error.
    hayakawa16 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    82e0f0f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ef12a2d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Finished unit tests for DetectorBinarySerialization in all detectors.…

    … Need to try toggling TallySecondMoment and test that.
    hayakawa16 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9b11460 View commit details
    Browse the repository at this point in the history
  2. Added ability to test with TallySecondMoment toggle between true and …

    …false. Tried to consolodate common code more, but don't think I can.
    hayakawa16 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6ca00c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    1ebf77f View commit details
    Browse the repository at this point in the history
  2. Single value detectors moved to separate files and placed in Vts.Test…

    ….Unit.MonteCarlo.Detectors folder and namespace. All unit tests pass.
    hayakawa16 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    575a9d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Added OneTimeTearDown attribute to Clear_previously_generated_files m…

    …ethod so that it runs at Setup and TestDown.
    hayakawa16 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9eb6ad9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    94cfcd4 View commit details
    Browse the repository at this point in the history
  2. Finished separating 2D detector unit tests into their own files. This…

    … is the biggest group. I'm over the hump!
    hayakawa16 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6a8335a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    553ab02 View commit details
    Browse the repository at this point in the history
  4. Finished separating 4D and 5D detectors and removed original Detector…

    …BinarySerializationTests that included all of the tests. Now I need to make sure the tests cleanup all generated test files properly.
    hayakawa16 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6b92e9e View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' into feature/112-reconfigure-the-detectors-to-u…

    …se-global-code-for-the-binary-serializers_2
    hayakawa16 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1b1ddbe View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    5f4f183 View commit details
    Browse the repository at this point in the history
  2. More code smell fixes

    hayakawa16 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c9e3ab4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    2624f37 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    24e0b13 View commit details
    Browse the repository at this point in the history
  2. One unit test dMCdRORhodMusDetectorTests had wrong detector specified…

    … in test. I could tell this by the lack of code-coverage shown for GetBinarySerializers in this detector. Rest indentation fixes or consolidation of array specifications.
    hayakawa16 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1e66b63 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Configuration menu
    Copy the full SHA
    452398a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    cb71fd7 View commit details
    Browse the repository at this point in the history