Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/145 bug found in dmcdrofrhodmusdetector #146

Merged
merged 6 commits into from
May 3, 2024
Merged

Bugfix/145 bug found in dmcdrofrhodmusdetector #146

merged 6 commits into from
May 3, 2024

Commits on May 2, 2024

  1. Bug found in dMCdROfRhodMusDetector. Fixed that and cleaned up code i… 

    …n dMuaDetector with comments. Renamed unit tests for DAW and CAW OneLayerDetectors to include "dMC" in name because added derivative detector tests.
    @hayakawa16
    hayakawa16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8fff1a1 View commit details
    Browse the repository at this point in the history

  2. Applied simplified equations.

    @janakarana
    janakarana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    661d237 View commit details
    Browse the repository at this point in the history

  3. Merged my edits with prior push.

    @hayakawa16
    hayakawa16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6529314 View commit details
    Browse the repository at this point in the history

  4. Cleaned up code per two new sonarcloud issues, i.e. two methods had i… 

    …dentical code. That is because derivative Radon-Nikodym factor is same for DAW and CAW.
    @hayakawa16
    hayakawa16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    906b80b View commit details
    Browse the repository at this point in the history

  5. Cleaned up issue with 2 issues with switch statement on the absorptio… 

    …n weighting type: 1) added Analog option so switch encompasses all enum types, and 2) removal of the empty case clause.
    @hayakawa16
    hayakawa16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    042d944 View commit details
    Browse the repository at this point in the history

  6. Added unit tests to test specification of AbsorptionWeightingType.Ana… 

    …log and the resulting exception.
    @hayakawa16
    hayakawa16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    fdd6f3a View commit details
    Browse the repository at this point in the history