Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 rfx tallies assume a homogeneous or layered tissue geometry #162

Merged

Commits on Sep 13, 2023

  1. Modified the SimulationInputValidation code to allow user specifying …

    …inhomogeneous tissue and ROfFx detector. Also performed code cleaned up on these two files. Since the ValidationResult.IsValid now returns true, simulation will proceed without interruption. This means that the ValidationRule set to "Warning: R(fx) theory assumes a homogeneous or layered tissue geometry" and the Remarks set to "User discretion advised" are not put to the screen since only results with IsValid=false put out these statements.
    hayakawa16 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fdb09c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Some more code cleanup.

    hayakawa16 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    59f858b View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    1634d11 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    277b131 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'master' into 13-rfx-tallies-assume-a-homogeneous-or-lay…

    …ered-tissue-geometry and resolved conflicts:
    
    #	src/Vts/MonteCarlo/DataStructuresValidation/SimulationInputValidation.cs
    hayakawa16 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    868bad9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    6443ae1 View commit details
    Browse the repository at this point in the history
  2. Modified validation code check of non-layered or non-homogeneous tiss…

    …ue and R(fx) detector specification to issue Warning and continue with simulation.
    hayakawa16 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0b3839f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2b8a37c View commit details
    Browse the repository at this point in the history
  4. Downgraded three more validation checks from an exception that stops …

    …the code, to issuing a warning and continuing on with the simulation.The philosophy here is that if combination of inputs is non-standard but the transport will not error, a warning is issued and the validation result remains true. This allows users to specify inconsistent combinations, e.g. angled source and cylindrical coordinate detectors, receive a warning and have the simulation proceed. If the combination of inputs will cause the transport to error, e.g. defining an embedded ellipsoid that overlaps with a tissue layer, then the input validation fails and the simulation stopped.
    hayakawa16 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5306b4a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9331e5a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Modfied one of the floating point comparisons using a range. The othe…

    …r should not have a range.
    hayakawa16 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    89e1b62 View commit details
    Browse the repository at this point in the history
  2. Fixed unused usings, code cleanup, cognitive complexity in one place …

    …and floating point check.
    hayakawa16 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    08b3354 View commit details
    Browse the repository at this point in the history
  3. Reduced complexity some more. Gave in and modified floating point che…

    …ck. Replaced Count() with Length and reduced long lines.
    hayakawa16 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ecc056f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    08daa7a View commit details
    Browse the repository at this point in the history
  5. Reduced complexity some more. And renamed Incapabilities to Capabilit…

    …ies in method names because not just incapabiities being checked, consistencies being checked too.
    hayakawa16 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    16412e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    b084325 View commit details
    Browse the repository at this point in the history
  2. Added more unit tests

    hayakawa16 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    db40c98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    648b186 View commit details
    Browse the repository at this point in the history