Feature/11 synchronize the mccl code with the one included in the vts repo #12
Conversation
…L application Remove the UnitTestCoverage because it did not work for the code coverage Remove the SonarCloudAnalysis file because this is handled in a action
…l to the one in MCCL
There was a problem hiding this comment.
Line 26 puts out version "1.0". Should we edit this to match MCCL Program: GetVersionNumber(3)}\n"); ?
There was a problem hiding this comment.
Yes we should! Nice catch! I'll update it on the VTS branch first and commit here also.
There was a problem hiding this comment.
I am visually reviewing. What is best way for me to programmatically review MCCL and MCPP Program,Setup and tests?
There was a problem hiding this comment.
We should review the changes on the VTS repo first:
VirtualPhotonics/VTS#108
Once we have reviewed on VTS, those changes will be the same here, you can just clone this repo locally and build and run the unit tests.
There was a problem hiding this comment.
Oh, I see now I think. I can view these same changes on 107?
|
Kudos, SonarCloud Quality Gate passed! |
They don't completely match, this branch contains all the changes since the last release. |
|
I see. I've reviewed those additional changes on prior PRs though correct? |
|
The csproj files are not the same, the VTS repo uses the VTS project and this repo uses the NuGet library so there are a few differences. It might be good to clone and make sure it runs as expected, we don't have a BuildTestRelease for this repo, we can discuss adding something for this repo. |
|
I have merged the branch in the VTS repo but I will hold off on merging this one until after we meet so we can go over the changes together. |
|
Makes sense on the csproj files. And yes we can discuss next Wednesday. |
lmalenfant
deleted the
feature/11-synchronize-the-mccl-code-with-the-one-included-in-the-vts-repo
branch
Since we have not made any MCCL specific changes to the VTS since the last release, I was able to update the MCCL repo with the recent changes from the VTS repo. This PR has the same changes as the branch on the VTS repo so we should validate there first and then we can validate and merge this one. Creating this PR alongside the VTS one will allow us to perform the SonarCloud checks, these only run on the MonteCarlo repo.
I didn't want to wait until the next release to make these changes because we had some more complex changes (shared cs files) and they could have caused problems.
VirtualPhotonics/VTS#108