Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models that are hard dependency of another scale from which they were defined are not taken into account yet.
What we need to do is:
Step 1 is done already, but there is much difficulty with step 2.
The inputs and outputs variables are used for two distinct purposes:
If we update the variables of the parent model, they will be used to compute the soft dependencies at the scale of the parent model. This is not desired because the variable is not computed at this scale but at the other scale, so it is not present in the parent scale status.
We need to be more explicit on the way we manage variables and scales. We should probably use wrappers around variables in the dependency nodes already, to be sure where a variable is computed. Caution: the variables from the multiscale hard-dependency models are not multiscale variables! The models are just run from another scale, but the status is the one at the scale of the hard-dependency model.