Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cs setup' tests #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

julienrf
Copy link

Requires a release of Coursier after coursier/coursier#2657 is merged.

@julienrf julienrf marked this pull request as ready for review January 20, 2023 16:07
@julienrf julienrf marked this pull request as draft January 20, 2023 16:07
@julienrf julienrf marked this pull request as ready for review January 23, 2023 11:16
@sideeffffect

This comment was marked as resolved.

@julienrf
Copy link
Author

julienrf commented Jan 23, 2023

Interesting, it failed with “no main class found” during the cs setup execution: https://github.com/VirtusLab/coursier-m1/actions/runs/3985837517/jobs/6834993515#step:7:351

@julienrf
Copy link
Author

I won’t be able to look at the underlying issue, unfortunately. If someone with an M1 architecture wants to help, that would be very much appreciated!

@julienrf
Copy link
Author

It fails because cs setup tries to install sbtn, and while doing so it tries to build a native launcher (because there is no one yet on macOS and aarch64, see sbt/sbt#7143), and fails to do it.

@julienrf
Copy link
Author

Follow-up PR: sbt/sbtn-dist#4

@julienrf
Copy link
Author

I cannot reproduce the issue locally. cs setup did work on my M1:

./cs setup --jvm 17  
Checking if a JVM is installed
  No JVM found, should we try to install one? [Y/n] y
  Should we update ~/.profile, ~/.zprofile? [Y/n] 
Some shell configuration files were updated. It is recommended to close this terminal once the setup command is done, and open a new one for the changes to be taken into account.

Checking if ~/Library/Application Support/Coursier/bin is in PATH
  Should we add ~/Library/Application Support/Coursier/bin to your PATH via ~/.profile, ~/.zprofile? [Y/n] 

Checking if the standard Scala applications are installed
  Installed ammonite
  Installed cs
  Installed coursier
  Installed scala
  Installed scalac
  Installed scala-cli
  Installed sbt
  Installed sbtn
  Installed scalafmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants