Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cats #5

Merged
merged 16 commits into from
Mar 4, 2024
Merged

Cats #5

merged 16 commits into from
Mar 4, 2024

Conversation

KacperFKorban
Copy link
Member

No description provided.

@KacperFKorban KacperFKorban marked this pull request as ready for review June 22, 2023 15:00
adamw
adamw reviewed Jul 15, 2023
View reviewed changes
README.md
The goal of the system is to check password security and return the information if the given password (or password hash) is safe to be used. For each check request we will try to crack the password or check it against common known leaks.
The system can be fed with a stream of plain text password combinations that should be forbidden to use (treated as easy to crack).
What exemplary problem VSS bootstrap solves?
The goal of the system is to get password hashed or check whether a given password hash has been queried before.

![VSS bootstrap architecture](docs/architecture.drawio.svg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] the drawing is very hard to read with dark mode :)

@KacperFKorban
Review fixes and reworks
1c4f675 
- Change creating servers into a single `make` method, instead of an
  implicit instance construction
- Add index on password_hash and remove password from passwords table
- Move endpoint interpretation into single interpreter
- Remove unused code and clarify comments
LukBed
LukBed requested changes Aug 14, 2023
View reviewed changes
vss-cats/src/main/protobuf/password.proto Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
vss-cats/src/main/scala/com/virtuslab/vss/cats/stats/grpc/services/StatsGrpcService.scala Show resolved Hide resolved
vss-cats/src/main/scala/com/virtuslab/vss/cats/stats/grpc/services/StatsGrpcService.scala Show resolved Hide resolved
vss-cats/src/main/scala/com/virtuslab/vss/cats/base/http/BaseHttpServer.scala Outdated Show resolved Hide resolved
vss-cats/src/main/scala/com/virtuslab/vss/cats/base/http/routes/PasswordRoutes.scala Show resolved Hide resolved
vss-cats/src/main/scala/com/virtuslab/vss/cats/base/services/Passwords.scala Show resolved Hide resolved
@lbialy lbialy merged commit 720464e into main Mar 4, 2024
@lbialy lbialy deleted the cats branch March 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukBed LukBed LukBed requested changes

@liosedhel liosedhel liosedhel left review comments

@adamw adamw adamw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KacperFKorban @adamw @liosedhel @LukBed @lbialy