-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add macho module doc #1100
base: master
Are you sure you want to change the base?
add macho module doc #1100
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This is a 👍 for me. Would be nice to get this merged in |
@plusvic is there anything i can do to help to merge this PR? |
The last time I tried to enable the "macho" module by default both Coverity and ASAN found issues that original author never got fixed. For that reason this module is still disabled by default and not documented. I didn't want to encourage people to use it, knowing that it may have security issues. @knightsc did some refactoring long ago, so the first thing I'll do is enable back and see what ASAN finds. Do you guys have used this module in production? Never had any problem with it? |
I'm using it and I didn't have any issues so far, but I definitely didn't try all methods |
I'm interested in this module, thanks for documenting it! interested if other folks are running this in production and why this PR wasn't addressed if it's available? |
I'm also interested. |
It should resolve a part of #1058 issue.