Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macho module doc #1100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add macho module doc #1100

wants to merge 2 commits into from

Conversation

nyx0
Copy link
Contributor

@nyx0 nyx0 commented Jul 31, 2019

It should resolve a part of #1058 issue.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nyx0
Copy link
Contributor Author

nyx0 commented Jul 31, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@knightsc
Copy link
Contributor

knightsc commented May 4, 2020

This is a 👍 for me. Would be nice to get this merged in

@nyx0
Copy link
Contributor Author

nyx0 commented Aug 18, 2020

@plusvic is there anything i can do to help to merge this PR?
Thank you

@plusvic
Copy link
Member

plusvic commented Aug 20, 2020

The last time I tried to enable the "macho" module by default both Coverity and ASAN found issues that original author never got fixed. For that reason this module is still disabled by default and not documented. I didn't want to encourage people to use it, knowing that it may have security issues. @knightsc did some refactoring long ago, so the first thing I'll do is enable back and see what ASAN finds.

Do you guys have used this module in production? Never had any problem with it?

@nyx0
Copy link
Contributor Author

nyx0 commented Aug 21, 2020

I'm using it and I didn't have any issues so far, but I definitely didn't try all methods

@Derekt2
Copy link

Derekt2 commented Dec 20, 2021

I'm interested in this module, thanks for documenting it! interested if other folks are running this in production and why this PR wasn't addressed if it's available?

@HydraDragonAntivirus
Copy link

I'm also interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants