Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PE module when scanning memory and fix PE certificate parsing #1657

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

niallnsec
Copy link

Addresses #1372 and #1392

* The X509_NAME_oneline function was being used to extract the certificate issuer and subject. The function
is being provided a static buffer which is only 254 chars in size, meaning that if either string is larger they will
be truncated and essential information may be lost.
* Increasing the buffer size or using a dynamic buffer could solve the issue, however the X509_NAME_oneline
function is deprecated and its use is strongly discouraged. Instead, the issue can be fixed using the newer
X509_NAME_print_ex function which will output the full string in a standard format.
* Unicode data is escaped in the output string by default, so ASN1_STRFLGS_ESC_MSB is explicitly cleared to
force the output of UTF8 encoded data. This allows matching unicode byte sequences in a more natural
and expected manner.
* This change has the side effect of addressing VirusTotal#1392
@niallnsec niallnsec force-pushed the master branch 3 times, most recently from 0d6be86 to 5d498a4 Compare March 1, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant