Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Dockerfile #355

wants to merge 1 commit into from

Conversation

Aurelien-VB
Copy link
Contributor

Fix typing error in dockerfile

@Aurelien-VB Aurelien-VB self-assigned this Apr 28, 2023
@Data-Iab Data-Iab self-requested a review May 10, 2023 10:06
Data-Iab
Data-Iab requested changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@Data-Iab Data-Iab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arg is not used anyway. You can add pycuda installation command as well at the end. It's isolated but needed for prod

@Aurelien-VB
Copy link
Contributor Author

It is actually used line 52. I'm not even sure how this docker file work with the typing error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab requested changes

@thibo73800 thibo73800 Awaiting requested review from thibo73800

Requested changes must be addressed to merge this pull request.

Assignees

@Aurelien-VB Aurelien-VB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aurelien-VB @Data-Iab