BUG: Version 1.5.1 less than required v1.5.0 when running pigeon v1.5.1 from release.

[taariq]

What is happening?

Section description

Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

1. New pigeon release:
   https://github.com/palomachain/pigeon/releases/tag/v1.5.1

2. Users download and build and then unjail.
   Error: pigeon is out of date. Version 1.5.1 less than required v1.5.0
   https://github.com/palomachain/paloma/blob/8b1dde09b1dfb43917f691bd554ade077b9e992c/app/app.go#L144

Paloma and pigeon versions and logs

Section description

Write down paloma version. Write down pigeon version. Copy and paste pigeon config file as well as relevant ENV variables.

App version: 1.5.1
Build commit hash: ada161d3817cdced7aa3e9b98bb6ff37d4427933

How to reproduce?

Section description

Please write detailed steps of what you were doing for this bug to appear.

Pigeon version upgrade must not halt pigeon.

[byte-bandit]

This issue is connected to how our semver library interprets version numbers. I downloaded both pigeon 1.5.0 and pigeon 1.5.1 and ran them in private test net against paloma 1.6.1 without any issues.

The version output for pigeon reads: v.1.5.x

Our current implementation expects the version to be starting with v. It appears that building from source and not tagging appropriately will lead to a version without a leading v, i.e. simply 1.5.0.

Without the leading v, our semver comparison interprets it as invalid and will always report as too low.

I am working on a fix, we can include it in the next planned Pigeon release.

[byte-bandit]

Also see: https://pkg.go.dev/golang.org/x/mod/semver#pkg-overview

Package semver implements comparison of semantic version strings. In this package, semantic version strings must begin with a leading "v", as in "v1.0.0".

[taariq]

palomachain/pigeon#228 fixed by @byte-bandit