Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🔧 Ensure v-prefixed version report #228

Merged
merged 1 commit into from
Jul 30, 2023
Merged

fix: 🔧 Ensure v-prefixed version report #228

merged 1 commit into from
Jul 30, 2023

Conversation

byte-bandit
Copy link
Collaborator

@byte-bandit byte-bandit commented Jul 30, 2023 •
edited
Loading

Related Github tickets

Background

Package semver implements comparison of semantic version strings. In this package, semantic version strings must begin with a leading "v", as in "v1.0.0". Our current keep-alive implementation fails if the version is not prefixed with a v.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

taariq
taariq approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taariq taariq merged commit 64e68a0 into palomachain:master Jul 30, 2023
1 check passed
@taariq taariq deleted the clohr/fix-invalid-semver branch July 30, 2023 10:01
@taariq taariq mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taariq taariq taariq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byte-bandit @taariq