Spartacus #1046
Closed
Spartacus #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a live stream with details how to asamble the and here is a video with the Toolhead in action Regarding the if was tested. |
|
Removed Paypal link
|
MapleLeafMakers
suggested changes
May 12, 2024
printer_mods/dury10/Spartacus/STL/45_degrees_strain_rellief_cover.stl
Outdated
Show resolved
Hide resolved
- shrieked the file size - corrected corrupted files - updated yml file - added Rapido UHF
adding guide how to assemble the toolhead
added Spartacus_step.7z
|
I have corrected the orientation and the yml file. Regarding the step file I have made an achieve and it cannot be less than 4mb @MapleLeafMakers any suggestions? |
4MB is no problem, you can remove the 7z version though, just the .stp is fine |
Ok i have removed the 7z file |
|
|
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅STL corruption checker
File checker
Readme generator
STL rotation checker
WARNING:
|
| Item | Result | Reason |
|---|---|---|
| dury10/Spartacus/CAD/Spartacus_step.stp | This file is larger than 2 MB! |
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
jontek2
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Hey! Just did a quick review of your PR and here is some feedback:
-
Please update the description in the metadata.yml. Try to describe your mod with 1-2 short sentences.
-
There are some parts that requires support to be printed nicely, such as "Klicky_holder.stl" and "idler.stl". For those parts we typically model in built in supports.
-
On v6_heatsink_mod.md you have spelling errors, see "Congratuletion now let's asamble the toolhead".
Could you please take a look into these points? Thanks!
|
@dury10 Thanks for submitting this mod. After some internal discussion I have decided to reject this mod. Please find my explanation below: Spartacus is a very complex mod to the VoronDesign 3D printer ecosystem. A lot of configurations and different variants are supported. As a result, this will likely cause the community to have a lot of feature requests and also may find some bugs while using it. You may wish to incorporate these features or fix these bugs. VoronUsers is not equipped to handle such development as feature requests and bugfixes (beyond simple things) are out of scope here. Here is my suggestion: Put Spartacus into its own github repository. This has the following advantages:
I'm sorry it has taken me this long to come to this conclusion, especially since you have already put a lot of work in to fix the concerns the other reviewers (and our CI) have had with the mod. I look forward to seing Spartacus get the exposure it deserves, and the possibility of it becoming an established alternative for toolheads in the Voron printer ecosystem. If you have any further questions, please reach out to me on discord (Haribro) Sorry again, and best of luck Florian (Haribro) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which mods are added by this PR?
How was it tested?
Any background context you want to provide?
Screenshots (if appropriate)
my mod adheres to these rules.
license