Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

300mm-x-extruder #1047

Merged
merged 16 commits into from
May 26, 2024
Merged

300mm-x-extruder #1047

merged 16 commits into from
May 26, 2024

Conversation

SGr33n
Copy link
Contributor

@SGr33n SGr33n commented May 16, 2024

Which mods are added by this PR?

300mm X Extruder endcaps

How was it tested?

Printing it and using on my own Enderwire

Any background context you want to provide?

I was not able to chop the X Extruder so I decided to buy a 300mm version, which is smaller than the one suggested on the main guide, so I designed that endcaps to fill the gaps.

Screenshots (if appropriate)

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

  • [ yes ] I have read the rules available here and
    my mod adheres to these rules.
  • [ yes ] This mod was created by myself and I agree to publish it under the repository
    license

Copy link
Collaborator

@mjonuschat mjonuschat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your mod. There are a few minor issues in the metadata.yml file that should be easy to correct.
The bigger issue is the printability of the left endcap with the embossed logo, it doesn't look like it's easily printable without supports, could you take a look at that and either add some instructions on how to correctly print it without supports to the readme or make some changes that improve printability.

More a question than a request for change: Would it make sense to rename the mod to "300m X-Extrusion Endcap" to help discoverability?

Copy link
Collaborator

@mjonuschat mjonuschat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, looks good to me.

@SGr33n
Copy link
Contributor Author

SGr33n commented May 19, 2024

Good, thanks :)

Copy link
Collaborator

@chirpy2605 chirpy2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetic
Copy link

thetic commented May 19, 2024

Extruder -> Extrusion? Current naming is very confusing.

@SGr33n
Copy link
Contributor Author

SGr33n commented May 19, 2024

Extruder -> Extrusion? Current naming is very confusing.

Extrusion, you're right.
I'll make the changes, can I also modify the dir name?

@MapleLeafMakers
Copy link
Collaborator

Extrusion, you're right. I'll make the changes, can I also modify the dir name?

Yes, rename the dir also, so that everything matches, and then 👍 from me!

@SGr33n
Copy link
Contributor Author

SGr33n commented May 23, 2024

Extrusion, you're right. I'll make the changes, can I also modify the dir name?

Yes, rename the dir also, so that everything matches, and then 👍 from me!

I also renamed the branch name, shall I open a new pull request?
Thanks

Copy link

Hi, thank you for submitting your PR.
Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
sgr33n/300mm-x-extrusion-endcap ✅ SUCCESS This mod makes stabler and prettier the use of a 300mm profile for... VSW

Tool check results overview:

Tool ⚠️ 💀
Mod structure checker
File checker 9
STL corruption checker 2
Readme generator 1
STL rotation checker 2
Markdown link checker 4

Tool check results details:

SUCCESS: ✅

File checker

Item Result Reason
sgr33n/300mm-x-extrusion-endcap/README.md ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/.metadata.yml ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/Images/gallery-2.jpg ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/Images/300mm-X-Extrusion-Endcap-X-2020-Profile.jpg ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/Images/300mm-X-Extrusion-Endcap-X-Carriage.jpg ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/Images/gallery-1.jpg ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/CAD/300mm_X-Extrusion_Endcap.step ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/STL/x_extrusion_endcap_left.stl ✅ SUCCESS
sgr33n/300mm-x-extrusion-endcap/STL/x_extrusion_endcap_right.stl ✅ SUCCESS

STL corruption checker

Item Result Number of STL fixes applicable
x_extrusion_endcap_left.stl ✅ SUCCESS 0
x_extrusion_endcap_right.stl ✅ SUCCESS 0

Readme generator

Item Result Description/Error Printer compatibility/Error Detail
sgr33n/300mm-x-extrusion-endcap ✅ SUCCESS This mod makes stabler and prettier the use of a 300mm profile for... VSW

STL rotation checker

Item Result Original orientation Suggested orientation
x_extrusion_endcap_left.stl ✅ SUCCESS
x_extrusion_endcap_right.stl ✅ SUCCESS

Markdown link checker

Item Result Reason
sgr33n/300mm-x-extrusion-endcap/README.md ✅ SUCCESS Relative link 'Images/300mm-X-Extrusion-Endcap-X-Carriage.jpg' is valid!
sgr33n/300mm-x-extrusion-endcap/README.md ✅ SUCCESS Relative link 'Images/300mm-X-Extrusion-Endcap-X-2020-Profile.jpg' is valid!
sgr33n/300mm-x-extrusion-endcap/README.md ✅ SUCCESS Relative link 'Images/gallery-1.jpg' is valid!
sgr33n/300mm-x-extrusion-endcap/README.md ✅ SUCCESS Relative link 'Images/gallery-2.jpg' is valid!


I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

@MapleLeafMakers
Copy link
Collaborator

Extrusion, you're right. I'll make the changes, can I also modify the dir name?

Yes, rename the dir also, so that everything matches, and then 👍 from me!

I also renamed the branch name, shall I open a new pull request? Thanks

No need, this is good, thanks for your submission!

@newphreak newphreak merged commit 2ef5d44 into VoronDesign:main May 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants