Rs 50 5 bracket #1050
Merged
Rs 50 5 bracket #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first attempt at submitting a mod, sorry if I messed anything up!
And here's the second one I'd like to submit.
removed another mod I want to submit.
|
Hi @Rikers-Beard, The CI-bot has detected an issues, could you please attend to that? Also a few minor details i've noticed upon review:
Other than that it looks good to me! |
|
Hi, thanks for reviewing my submission. This is my first time submitting
mods, sorry for any hiccups.
1.) I go by "Riker's Beard" on the voron discord and other related 3D
printing channels. My discord username wasnt as "family friendly", I've
changed it to be more relevant and will update my two submissions now.
2.) I only listed V2.4r2 compatibility because the guide states to "Please
only specify printers that you have either tested your mod on yourself, or
that someone else has tested for you". I have not found anyone else to test
this mod for me yet, I will add "VT" and others with your approval.
Thanks for your help, feel free to revise printer compatibilities as you
see fit from your end if possible.
…On Tue, Jul 2, 2024, 9:45 AM Jonathan Hellman ***@***.***> wrote:
Hi @Rikers-Beard <https://github.com/Rikers-Beard>,
The CI-bot has detected an issues, could you please attend to that?
Also a few minor details i've noticed upon review:
- Your discord_username is probably wrong, seems like you put the
screenname and not the username.
- Any reason for not including the trident in "Printer Compability"?
Other than that it looks good to me!
—
Reply to this email directly, view it on GitHub
<#1050 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJSSMKVR7VGYEGNJKPTGENDZKLKKZAVCNFSM6AAAAABKGYNDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHAYDQMRXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Okay username is corrected in the metadata.yml, added VT to list of compatibilities, this one should be good to go now. I also corrected the metadata in my other pending submission. Thanks. |
|
I'm confused as to why I am still getting errors on the checklist, I followed the sample_mod template and organized the file structure as directed. I'm standing by to make the necessary corrections. |
I removed an empty line in the description that was used to space the sentences, maybe that fixed it?
Forgot to add a space after a period in description, corrected.
|
Thanks for the updates. I think the error lies in description in the metadata-file, could you please try a shorter? Maybe something like "A Meanwell RS-50-5 PSU DIN rail mount bracket" or something? Longer text can be put in the README-file. |
|
Okay, that makes sense. I'll revise both mod submissions accordingly. Thank you. |
shortened description per advice.
|
Both PRs revised. |
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅STL corruption checker
File checker
Readme generator
Markdown link checker
STL rotation checker
I am a 🤖, this comment was generated automatically! Made with ❤️ by the VoronDesign GitHub Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which mods are added by this PR?
How was it tested?
Any background context you want to provide?
Screenshots (if appropriate)
my mod adheres to these rules.
license