Z-Top Idlers #1054
Closed
Z-Top Idlers #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Itzo1978, Looks like the bot has spotted issues with the metadata file. Seems like it contains unwanted characters. I also noted that you uploaded 3mf files, but in the metadata refer to them as stl's. Could you change them to stls? |
|
Hey,
I hadn't paid attention to the extension used.
It's been corrected
Thank you for reporting
Le dim. 22 sept. 2024 à 13:04, Jonathan Hellman ***@***.***>
a écrit :
… Hey @Itzo1978 <https://github.com/Itzo1978>,
Looks like the bot has spotted issues with the metadata file. Seems like
it contains unwanted characters.
I also noted that you uploaded 3mf files, but in the metadata refer to
them as stl's. Could you change them to stls?
—
Reply to this email directly, view it on GitHub
<#1054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXY4VM3M3EKLT2UIYSFDU73ZX2P3HAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWG4ZDOOBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Itzo1978 As i was typing i saw that you pushed some changes, hehe. Seems like there's still a typo with "cad :" where it should be "cad:". I'll run the bot and see if there's any other changes needed aswell. |
github-actions
bot
added
CI: Issues identified
and removed
Ready for CI
CI: Issues identified
labels
|
Maybe a anothers problems : a space between Top and Idlers ?
I don't know how to change... I'm discovering these features 🙈
Le dim. 22 sept. 2024 à 17:15, Jonathan Hellman ***@***.***>
a écrit :
… @Itzo1978 <https://github.com/Itzo1978> As i was typing i saw that you
pushed some changes, hehe.
Seems like there's still a typo with "cad :" wherte it should be "cad:".
I'll run the bot and see if there's any other changes needed aswell.
—
Reply to this email directly, view it on GitHub
<#1054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXY4VM2EQICDXMO34BM22H3ZX3NKDAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHAZTEMJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No worries, we'll figure it out. I belive you have some naming issues with your files vs the yml file. If you look at the yml file it says: cad:
Where the actual filenames are: CAD/[a]_ztop_tensioner_9mm_x4.step Please update this and i'll run the bot again. |
|
and now ?
Le dim. 22 sept. 2024 à 17:27, Jonathan Hellman ***@***.***>
a écrit :
… No worries, we'll figure it out.
I belive you have some naming issues with your files vs the yml file. If
you look at the yml file it says:
`cad:
- CAD/[a]_z-top_tensioner_9mm_x4.step
- CAD/z-top_tensioner_bracket_a_x2.step
- CAD/z-top_tensioner_bracket_b_x2.step`
Where the actual filenames are:
CAD/[a]_ztop_tensioner_9mm_x4.step CAD/ztop_tensioner_bracket_a_x2.step
CAD/ztop_tensioner_bracket_b_x2.step
Please update this and i'll run the bot again.
—
Reply to this email directly, view it on GitHub
<#1054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXY4VMZTKEV7KFRQGXX3P5TZX3OWNAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHAZTQNBUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅File checker
Readme generator
STL corruption checker
STL rotation checker
I am a 🤖, this comment was generated automatically! Made with ❤️ by the VoronDesign GitHub Team |
|
Hey @Itzo1978 , After internal discussion and review, we've decided to reject this mod submission as it does not meet our submission rules, specifically the "Mods must not represent slight modifications of existing mods/existing VoronDesign printer parts." However, you're more than welcome to upload it to platforms like Printables or other 3D model databases. If you have any questions, feel free to reach out to us on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What mods has this PR added?
Replacing the original Z Idlers with my model
How has it been tested?
It was tested on my machine, the Voron 2.4 (v2.3941)
Any context you wish to provide?
I noticed a deformation of the belts. It's moving forwards causing the belt to be a few millimetres out of alignment. Consequence: the Z height cannot be respected without a correction in klipper (with
distance_rotation)My model makes it possible to correct this phenomenon
Tightening the screw from above to tighten the belt is much easier than from below.
Screenshots (if appropriate)
in progress
my mod adheres to these rules.
license